Widgets/text area #4995
Open
Widgets/text area #4995
+3,963
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robob27
reviewed
Oct 9, 2024
robob27
reviewed
Oct 9, 2024
wiktor-obrebski
force-pushed
the
widgets/text-area
branch
from
509a0c1
to
83a9a19
Compare
|
I really appreciate your work on all of this stuff! You really went all out with this widget and the result is fantastic. Journal is sooo good and it's awesome that every other script will have such a great textarea to work with. I have been looking forward to this PR 😄 |
|
This PR looks good to me. My understanding is that this type of stuff (especially lua, ui) is primarily myk's area of responsibility to sign-off on, so it may take some time to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR introduce
TextAreawidget.This widgets is already in use in
gui/journaland cominggui/notestools.Its provide much better support for text manipultation than TextField do.
Scripts journal has been migrated here:
DFHack/scripts#1327