remove DFSDL.h dependency from Graphic.h
#5006
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this significantly reduces the number of compilation units that depend on DFSDL.h
lethosor
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
looks good to me. I think we already do this sort of thing in several places, so the comment could have potentially been just something like // from DFSDL.h, but no need to change it here - just not something that needs to be explained in detail every time, IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this significantly reduces the number of compilation units that depend on
DFSDL.hthis allows us to include more content into
DFSDL.hwithout as much compile-time loading;Graphic.his included byCore.hwhich is included by many many things, but only a handful of compilation units includeDFSDL.hdirectlythe only module that needed to be adjusted was
LuaApi.cpp