Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented a generalized version of the Map, LineChart, and Scenario components using VVAFER approach #367

Merged
merged 150 commits into from
Jul 23, 2024

Conversation

LorenzoSerloni
Copy link
Contributor

@LorenzoSerloni LorenzoSerloni commented Jun 13, 2024

Description

This PR implements a generalized version of the Map, LineChart, and Scenario components, replacing all previously used components. Each component now uses a data context to communicate, as suggested in the VVAFER paper futhermore we introduced the wrapper approach proposed for the Map & LineChart. The data context employs the useContext hook in React for component communication.

Related Issues

Design Decisions

This implementation is inspired by the VVAFER paper, which suggests using a centralized data socket to enhance communication between components.

Performance & Quality

Test coverage report: https://coveralls.io/jobs/144875985
Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1718809076688-87755.report.html

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

Violini and others added 30 commits May 29, 2024 14:28
…docs and fix major bug and also add the possibility to decide how many lines to show in the card when are folded and when are expanded
… major bug and also add the possibility to decide how many lines to show in the card when are folded and when are expanded
frontend/src/components/LineChartComponents/LineChart.tsx Outdated Show resolved Hide resolved
frontend/src/components/LineChartComponents/LineChart.tsx Outdated Show resolved Hide resolved
frontend/src/components/LineChartComponents/LineChart.tsx Outdated Show resolved Hide resolved
frontend/src/components/LineChartComponents/LineChart.tsx Outdated Show resolved Hide resolved
frontend/src/components/LineChartComponents/LineChart.tsx Outdated Show resolved Hide resolved
frontend/src/types/card.ts Outdated Show resolved Hide resolved
frontend/src/types/card.ts Outdated Show resolved Hide resolved
frontend/src/types/card.ts Outdated Show resolved Hide resolved
@LorenzoSerloni LorenzoSerloni merged commit d51f9b4 into develop Jul 23, 2024
8 checks passed
@LorenzoSerloni LorenzoSerloni deleted the feature/generalize branch July 23, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants