-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented a generalized version of the Map, LineChart, and Scenario components using VVAFER approach #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3aced9a.
…ion in missing files
…docs and fix major bug and also add the possibility to decide how many lines to show in the card when are folded and when are expanded
…nto feature/generalize
… major bug and also add the possibility to decide how many lines to show in the card when are folded and when are expanded
… new components props
…chart component should be bugless :)
…mchart component should be bugless :)
…chart component should be bugless :)
JonasGilg
requested changes
Jul 16, 2024
frontend/src/components/ScenarioComponents/CardsComponents/CardContainer.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/ScenarioComponents/CardsComponents/GroupFilter/FilterCard.tsx
Outdated
Show resolved
Hide resolved
JonasGilg
approved these changes
Jul 23, 2024
NXXR
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a generalized version of the Map, LineChart, and Scenario components, replacing all previously used components. Each component now uses a data context to communicate, as suggested in the VVAFER paper futhermore we introduced the wrapper approach proposed for the Map & LineChart. The data context employs the useContext hook in React for component communication.
Related Issues
Design Decisions
This implementation is inspired by the VVAFER paper, which suggests using a centralized data socket to enhance communication between components.
Performance & Quality
Test coverage report: https://coveralls.io/jobs/144875985
Lighthouse report: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1718809076688-87755.report.html
Checklist
I, the author of this PR checked the following requirements for good software quality:
I, the reviewer checked the following things: