Skip to content

Commit

Permalink
devtools: fix bashism in mailmap check
Browse files Browse the repository at this point in the history
When running check-git-log, it showed a "Bad substitution",
because of a bash syntax.

It is fixed by using sed to escape the open parenthesis.

Fixes: 6fd14c1 ("devtools: fix mailmap check for parentheses")
Cc: stable@dpdk.org

Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
  • Loading branch information
raslandarawsheh authored and tmonjalo committed Jul 12, 2023
1 parent dd33d53 commit 8aec1d8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion devtools/check-git-log.sh
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ names=$(git log --format='From: %an <%ae>%n%b' --reverse $range |
sed -rn 's,.*: (.*<.*@.*>),\1,p' |
sort -u)
bad=$(for contributor in $names ; do
contributor=${contributor//(/\\(}
contributor=$(echo $contributor | sed 's,(,\\(,')
! grep -qE "^$contributor($| <)" $selfdir/../.mailmap || continue
name=${contributor%% <*}
if grep -q "^$name <" $selfdir/../.mailmap ; then
Expand Down

0 comments on commit 8aec1d8

Please sign in to comment.