Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
hash: align SSE lookup to scalar implementation
__mm_cmpeq_epi16 returns 0xFFFF if the corresponding 16-bit elements are equal. In original SSE2 implementation for function compare_signatures, it utilizes _mm_movemask_epi8 to create mask from the MSB of each 8-bit element, while we should only care about the MSB of lower 8-bit in each 16-bit element. For example, if the comparison result is all equal, SSE2 path returns 0xFFFF while NEON and default scalar path return 0x5555. Although this bug is not causing any negative effects since the caller function solely examines the trailing zeros of each match mask, we recommend this fix to ensure consistency with NEON and default scalar code behaviors. Fixes: c7d93df ("hash: use partial-key hashing") Cc: stable@dpdk.org Signed-off-by: Feifei Wang <feifei.wang2@arm.com> Signed-off-by: Jieqiang Wang <jieqiang.wang@arm.com> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
- Loading branch information