infra: packet tracing #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjarry
requested changes
Oct 11, 2024
There was a problem hiding this comment.
Hi Chris,
Thank you for this. This is a precious tool to help understanding packet flow.
In addition of my code review remarks, I think this series should be split at least in 4 or 5 commits. You already list multiple independent changes in your commit message. You can start with this, but I think more fine grain commits would help a lot.
Cheers
christophefontaine
force-pushed
the
packet_tracing
branch
2 times, most recently
from
ed1ce08
to
09e1c0e
Compare
christophefontaine
force-pushed
the
packet_tracing
branch
2 times, most recently
from
cc0445c
to
5954b3e
Compare
christophefontaine
force-pushed
the
packet_tracing
branch
2 times, most recently
from
8cc6f57
to
eeae9af
Compare
|
Added trace cli to enable/disable globally and per interface packet tracing. |
rjarry
requested changes
Oct 17, 2024
christophefontaine
force-pushed
the
packet_tracing
branch
3 times, most recently
from
1f1e0f7
to
73d1c03
Compare
Add packet tracing infrastructure, to log packet traversal on nodes. Add CLI to enable/disable packet tracing per interface. Signed-off-by: Christophe Fontaine <cfontain@redhat.com>
Use trace api to enable/disable packet tracing for control_input node. Signed-off-by: Christophe Fontaine <cfontain@redhat.com>
Add ethertype and ip proto format functions Signed-off-by: Christophe Fontaine <cfontain@redhat.com>
Implement tracing functions for ethernet nodes. For vlan interfaces, enable tracing according to the user intent. Signed-off-by: Christophe Fontaine <cfontain@redhat.com>
Implement tracing function for arp input/output/output_request. Signed-off-by: Christophe Fontaine <cfontain@redhat.com>
Implement tracing for icmp_node node Signed-off-by: Christophe Fontaine <cfontain@redhat.com>
Implement tracing functions for ip nodes. Update tests to enable and show traces. Signed-off-by: Christophe Fontaine <cfontain@redhat.com>
Implement tracing for ipip nodes Signed-off-by: Christophe Fontaine <cfontain@redhat.com>
Implement tracing for ip6/icmp6/ndp nodes. Signed-off-by: Christophe Fontaine <cfontain@redhat.com>
Implement tracing and trace aggregate for control output node. Signed-off-by: Christophe Fontaine <cfontain@redhat.com>
christophefontaine
force-pushed
the
packet_tracing
branch
from
73d1c03
to
e90543d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepend a common structure for all mbuf priv data Prepend to all mbuf_priv data a common structure, which will include data available for the whole life of the packet.
Add packet tracing infra, to log the packet traversal on each node. Add CLI to enable/disable packet tracing per interface. Add relevant trace function on nodes.
'show trace' command is destructive and empties the ring.
Sample output: