Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/assets/i18n: update Finnish language strings #2347

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

alanorth
Copy link
Contributor

Description

Contributed by Reeta Kuukoski from the National Library of Finland. Consolidated from previous pull request:

Instructions for Reviewers

List of changes in this PR:

  • Updated Finnish language strings

Include guidance for how to test or review your PR.
Build the Angular UI and check to make sure the Finnish UI strings load and display properly.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alanorth alanorth added the i18n / l10n Internationalisation and localisation, related to message catalogs label Jun 30, 2023
@tdonohue tdonohue added this to the 7.6.1 milestone Jun 30, 2023
@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge label Jun 30, 2023
@alanorth alanorth changed the base branch from main to dspace-7_x July 4, 2023 04:59
@alanorth alanorth added the port to main This PR needs to be ported to `main` branch for the next major release label Jul 4, 2023
@tdonohue tdonohue self-requested a review July 27, 2023 14:12
Contributed by Reeta Kuukoski from the National Library of Finland.
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @reetagithub and @alanorth ! Gave this a quick test and the new Finnish translations look to be visible in the UI.

@tdonohue tdonohue merged commit 99c6dd1 into DSpace:dspace-7_x Aug 3, 2023
10 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for main:

@tdonohue tdonohue removed the port to main This PR needs to be ported to `main` branch for the next major release label Aug 3, 2023
@alanorth alanorth deleted the finnish-language-strings branch August 4, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs
Projects
Development

Successfully merging this pull request may close these issues.

3 participants