Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port dspace-7_x] Fix setStaleByHrefSubstring not emitting true when all requests are stale #2404

Conversation

alexandrevryghem
Copy link
Member

@alexandrevryghem alexandrevryghem commented Jul 27, 2023

artlowel and others added 3 commits June 30, 2023 16:56
…g-not-emitting-after-all-requests-were-stale_contribute-7.4' into fix-setStaleByHrefSubtring-not-emitting-after-all-requests-were-stale_contribute-7.6

# Conflicts:
#	src/app/core/data/request.service.ts
@alexandrevryghem alexandrevryghem self-assigned this Jul 27, 2023
@alexandrevryghem alexandrevryghem added bug 1 APPROVAL pull request only requires a single approval to merge labels Jul 27, 2023
@alexandrevryghem alexandrevryghem added this to the 7.6.1 milestone Jul 27, 2023
@alexandrevryghem alexandrevryghem changed the title Fix set stale by href subtring not emitting after all requests were stale contribute Fix setStaleByHrefSubstring not emitting true when all requests are stale Jul 27, 2023
@alexandrevryghem alexandrevryghem changed the title Fix setStaleByHrefSubstring not emitting true when all requests are stale [Port dspace-7_x] Fix setStaleByHrefSubstring not emitting true when all requests are stale Aug 2, 2023
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Reviewed/tested against main in #2349. This PR is identical and simply applies the changes to dspace-7_x.

@tdonohue tdonohue merged commit 97b2eb7 into DSpace:dspace-7_x Sep 7, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug
Projects
Development

Successfully merging this pull request may close these issues.

3 participants