Add basic e2e testing for i18n #3461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
added
i18n / l10n
tdonohue
force-pushed
the
i18n_e2e_test
branch
from
a3b4fe8
to
a74cd84
Compare
|
Merging immediately as this is a test that helps with |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3461-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3461-to-dspace-7_x
git switch --create backport-3461-to-dspace-7_x
git cherry-pick -x a74cd848feeabe380026f504f0e70f6de134fd65 |
|
Successfully created backport PR for |
tdonohue
removed
port to dspace-7_x
|
Ported to 7.x in #3468 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In testing the many
dependenciesrelated PRs fromdependabot, I've realized that a common test that I perform manually (in some scenarios) is to simply check if i18n translations are still working (by using the globe in the UI header)So, rather than do that manually, here's an e2e test that verifies the basics by checking that we can switch from English to German and back (and that everything works).
Instructions for Reviewers