Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port main] Remove unused dependencies (sortablejs, sanitize-html, webfontloader) #3511

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

tdonohue
Copy link
Member

Description

Manual port of #3509 to main. These three dependencies are not used on main either.

Instructions for Reviewers

  • Verify tests all still succeed.
  • If desired, test the UI. However, I've already done this.

@tdonohue tdonohue added dependencies Pull requests that update a dependency file 1 APPROVAL pull request only requires a single approval to merge labels Oct 21, 2024
@tdonohue tdonohue added this to the 9.0 milestone Oct 21, 2024
@tdonohue
Copy link
Member Author

👍 Passes all tests. I verified this is working locally. Also the 7.x version of this PR was already approved/merged. Merging immediately.

@tdonohue tdonohue merged commit 23bc4b2 into DSpace:main Oct 22, 2024
13 checks passed
@tdonohue tdonohue deleted the remove_unused_deps_main branch October 22, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge dependencies Pull requests that update a dependency file
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant