Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port dspace-8_x] Remove unused PostCSS plugins #3548

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

tdonohue
Copy link
Member

Description

Manual port of #3547 to dspace-8_x. See details in that PR.

Tested this port PR manually & ensured there are no bugs introduced in 8.x themes. No issues found.

@tdonohue tdonohue added dependencies Pull requests that update a dependency file 1 APPROVAL pull request only requires a single approval to merge labels Oct 23, 2024
@tdonohue tdonohue added this to the 8.1 milestone Oct 23, 2024
@kshepherd
Copy link
Member

@tdonohue there are a few version bumps in yarn.lock as well, was that intentional?

@tdonohue
Copy link
Member Author

tdonohue commented Oct 24, 2024

@kshepherd : All the changes to yarn.lock were automated by running yarn remove [dependency] (e.g. yarn remove postcss-apply). So, the version changes you see were made by yarn as part of removing these dependencies. If you look closely, the yarn.lock changes are just removing some old versions of other dependencies which were used by these PostCSS plugins. (This is a good thing because it shows removing these PostCSS plugins removes other older dependencies from our yarn.lock)

So, the changes to yarn.lock were made by yarn itself. In that manner, they were intentional, because yarn saw necessary cleanup to make. :) Hopefully that makes more sense!

Copy link
Member

@kshepherd kshepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving and merging backport of already-merged commit, tests well

@kshepherd kshepherd merged commit 882d09a into DSpace:dspace-8_x Oct 24, 2024
13 checks passed
@tdonohue tdonohue deleted the remove_unused_postcss_deps_8x branch October 24, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge dependencies Pull requests that update a dependency file
Projects
Development

Successfully merging this pull request may close these issues.

2 participants