-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused dependencies #3553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 tested successfully with dspace theme, all looks good to me!
Hi @tdonohue, |
@tdonohue i merged the postcss change which then introduced this merge conflict, whoops! |
@kshepherd : No worries! I'll get this cleaned up later today and will go ahead and merge it, since both you and I have tested it. I also have to create backports of this work for 8.x and 7.x (which I didn't find time for yesterday). Thanks for the quick review/test! |
f1c7272
to
3832851
Compare
Rebased this on latest |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3553-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3553-to-dspace-7_x
git switch --create backport-3553-to-dspace-7_x
git cherry-pick -x 217b72a3329329f5a8c83c4bb2c57982bd165b33 fef5dd72b30ca6174587f1a7dea8994f1e96bbc9 426a0ac4880dbfb2381685ab39222ce347e2bc1c 4c5b064cfb74c9aac263f405248c889e13c81bfe 3b00cc10809fdf801213066bfe64f6dde1996598 3832851ef4295924e079d3ee196ce455d21790eb |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-3553-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-3553-to-dspace-8_x
git switch --create backport-3553-to-dspace-8_x
git cherry-pick -x 217b72a3329329f5a8c83c4bb2c57982bd165b33 fef5dd72b30ca6174587f1a7dea8994f1e96bbc9 426a0ac4880dbfb2381685ab39222ce347e2bc1c 4c5b064cfb74c9aac263f405248c889e13c81bfe 3b00cc10809fdf801213066bfe64f6dde1996598 3832851ef4295924e079d3ee196ce455d21790eb |
I'll manually backport this to both 8.x & 7.x |
Description
This PR removes a number of dependencies defined in our
package.json
which are unused by our codebase. Some of these are optional dev tools. But, in my opinion, they can be installed by developers who need them, since DSpace doesn't use them in our code.One dependency moved from production to dev dependency:
@types/grecaptcha
- this is only needed for compilationUnused production dependencies removed:
angular-idle-preload
Unused development dependencies removed:
browser-sync
react
andreact-dom
rxjs-spy
webpack-bundle-analyzer
Instructions for Reviewers