Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't break on empty play key #87

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

Xiphoseer
Copy link
Contributor

remove the Optional() validator, which makes empty strings pass validation and fail later because the empty string is no valid key. Instead just rely on the fact that validate_play_key will never fail if REQUIRE_PLAY_KEY is not set.

@aronwk-aaron aronwk-aaron merged commit 2e4bd04 into main Jan 7, 2024
1 check passed
@aronwk-aaron aronwk-aaron deleted the fix/empty-play-key branch January 7, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants