Skip to content

Add Loot Table page, fix syntax mistakes - #148

Open
EricristianBros wants to merge 2 commits into
Datapack-Hub:mainfrom
EricristianBros:adding-loot-tables
Open

Add Loot Table page, fix syntax mistakes#148
EricristianBros wants to merge 2 commits into
Datapack-Hub:mainfrom
EricristianBros:adding-loot-tables

Conversation

@EricristianBros

Copy link
Copy Markdown
  • Add loot table page
  • Fix typos and syntax mistakes
  • Update version on pages that weren't marked for 26.2
  • Add small clarifications

- Add loot table page
- Fix typos and syntax mistakes
- Update version on pages that weren't marked for 26.2
- Add small clarifications
Comment thread src/routes/guide/performance/write-optimized-code/+page.svx Outdated

@HoodieRocks HoodieRocks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your PR! There were a lot of mistakes in the wiki it seems 😬, so I would like to thank you for fixing the glaring ones and updating some of the older pages as well. I have found a few small issues but otherwise a very well written PR.

Comment thread src/routes/wiki/command/all/+page.svx
Comment thread src/routes/wiki/files/loot-tables/+page.svx Outdated
Comment thread src/routes/wiki/info/breaking-changes/+page.svx Outdated

@Silabear Silabear left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing mistakes: There are some minor things I have suggested on some of the changed pages (some of which don't necessarily relate to these changes, but would still make sense to also be fixed in this PR), but overall I see very little issue with these changes. Please take a look at my comments and suggestions.

New loot tables page: Please refer to my comment on this file, and please reply to it before resubmitting for review.

Comment thread src/routes/guide/adding-new-features/custom-items/models/+page.svx Outdated
Comment thread src/routes/guide/adding-new-features/smithing-trims/+page.svx Outdated
Comment thread src/routes/guide/performance/how-to-measure/+page.svx Outdated
Comment thread src/routes/wiki/concepts/coordinates/+page.svx Outdated
Comment thread src/routes/wiki/files/loot-tables/+page.svx Outdated
Comment thread src/routes/wiki/files/loot-tables/+page.svx
Comment thread src/routes/guide/performance/write-optimized-code/+page.svx Outdated
Comment thread src/routes/guide/performance/write-optimized-code/+page.svx
Comment thread src/routes/guide/performance/write-optimized-code/+page.svx Outdated
Comment thread src/routes/wiki/info/breaking-changes/+page.svx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants