Upgrade to latest ruff

A few errors need fixing after upgrading, and one file is reformatted.

ws/models.py

@@ -815,6 +815,12 @@ class WinterSchoolSettings(SingletonModel):
         default=True, verbose_name="Accept new Winter School leader applications"
     )
 
+    def __str__(self):
+        return (
+            f"Applications: {'on' if self.accepting_applications else 'off'}, "
+            f"Lecture attendance: {'on' if self.allow_setting_attendance else 'off'}"
+        )
+
 
 class MentorActivity(models.Model):
     """An activity which can be mentored.
@@ -1750,6 +1756,9 @@ class Meta:
         abstract = True  # See model_from_activity for more
         ordering = ["time_created"]
 
+    def __str__(self) -> str:
+        return f"Application by {self.participant} to be leader in {self.year}"
+
     @property
     def rating_given(self):
         """Return any activity rating created after this application."""

ws/utils/geardb.py

@@ -41,7 +41,7 @@ class Rental(NamedTuple):
     """
 
     email: str
-    id: str  # Example, 'BK-19-04'  # noqa: A003
+    id: str  # Example, 'BK-19-04'
     name: str
     cost: float  # How much the daily cost for the item is
     checkedout: date

ws/views/participant.py

@@ -367,7 +367,7 @@ def get_stats(trips: GroupedTrips) -> list[str]:
             return []
 
         def count(
-            key: Literal["on_trip", "creator", "leader", "wimp", "waitlisted"]
+            key: Literal["on_trip", "creator", "leader", "wimp", "waitlisted"],
         ) -> str:
             matching_trips = trips["past"][key]
             assert matching_trips is not None  # waitlisted can be omitted

ws/views/trips.py

@@ -60,7 +60,7 @@ class TripView(DetailView):
     context_object_name = "trip"
     template_name = "trips/view.html"
 
-    object: models.Trip  # noqa: A003
+    object: models.Trip
 
     def get_queryset(self):
         trips = super().get_queryset().select_related("info")
@@ -147,7 +147,7 @@ class ReviewTripView(DetailView):
     template_name = "trips/review.html"
     success_msg = "Thanks for your feedback!"
 
-    object: models.Trip  # noqa: A003
+    object: models.Trip
     request: "RequestWithParticipant"
 
     @property
@@ -346,7 +346,7 @@ class EditTripView(UpdateView, TripLeadersOnlyView):
     form_class = forms.TripForm
     template_name = "trips/edit.html"
 
-    object: models.Trip  # noqa: A003
+    object: models.Trip
 
     def get_form_kwargs(self):
         kwargs = super().get_form_kwargs()