-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix an over-eager removal of a Celery task arg
In a previous commit, I removed the deprecated `lottery_config` argument from `run_lottery`, thinking I could safely just deprecate old messages by capturing `lottery_config` with `**kwargs`. Looking at this code, I now realize that `lottery_config` is being passed conditionally. To safely keep the lottery running on all current trips I need to: 1. Deploy this code 2. Restart Celery workers 3. Revoke all open messages identified by `trip.lottery_task_id` Step 3 can be accomplished by just editing all open lottery trips, making the close time marginally different.
- Loading branch information
Showing
2 changed files
with
3 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters