fix: crash in analytics.reset for aws pinpoint #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Calling analytics.reset leads to a crash on analytics-plugin-aws-pinpoint in the browser
Browser: Chrome Version 115.0.5790.114 (Official Build) (x86_64)
OS: OSX 12.6.5
Steps to reproduce:
Result: Crash with the following stacktrace
storage is not defined
ReferenceError: storage is not defined
at Object.reset (https://my.bundle.min.js:2099:7)
at https://my.bundle.min.js:2196:9319
Analysis:
The storage object is not defined but is being used to delete a key in the reset callback of the pinpoint plugin. I have just directly used the removeItem import and I am getting results as expected. Please verify if this is the correct fix @DavidWells