fix(self-host): keep Hermes webui alive after setup-agent exits - #43
Merged
Merged
Conversation
On macOS/IDE terminals, shell-spawned nohup children get SIGKILL'd when the process group tears down, so Agent tab dies right after setup reports ready. Prefer a LaunchAgent on Darwin, detach with setsid/disown elsewhere, and export HERMES_WEBUI_ALLOWED_ORIGINS for non-default frontend ports.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.deepsql.hermes-webui) so IDE/shell process-group teardown cannot SIGKILL the webui right aftersetup-agent.shreports ready.setsid/disowninstead of a barenohupchild of the setup script.HERMES_WEBUI_ALLOWED_ORIGINSfrom the frontend port (supports non-default ports like:3003).Test plan
./scripts/self-host/setup-agent.sh, confirmcurl http://127.0.0.1:8787/api/mcp/serversstays 200 after the script exitslaunchctl print gui/$(id -u)/com.deepsql.hermes-webuishowsstate = runningsetup-agent.shreloads the LaunchAgent cleanly