fix(dashboards): emit SSE chat event so greetings are not treated as builds - #46
Merged
Merged
Conversation
…builds Out-of-context messages like "hi" were correctly classified as chat-only, but still arrived on the done event. The workspace done handler always appends the canned "Done — built…" line, so greetings looked like rebuilds.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"hi") now stream as a dedicated SSEchatevent instead of reusingdone.chatseparately and guards the workspaceonDonepath so a chat-shaped payload cannot append the canned “Done — built…” save message or clobber the artifact.Why
Sumit’s chat-intent classifier in #42 was working (Hermes ran the greeting task), but the UI still showed “Done — built and verified…” because that line is hardcoded on the build-success path, which was driven by the shared
doneevent.Test plan
hidoneand saves as beforecurl/SSE:prompt=hiyieldsevent:chatand noevent:done