feat(oss): E2E fix proposal MVP — multi-schema Brain, Agent auth, onboarding - #48
Merged
Merged
Conversation
Close the OSS launch blockers from docs/oss-ux/E2E_FIX_PROPOSAL.md: - W2a/b: Postgres Brain scans all non-system schemas with qualified keys; coverage gate fails or NEEDS_ATTENTION instead of fake Complete 100% - W1: provisioner writes DEEPSQL_TOKEN_FILE, fail-loud provision, MCP auth probe + Agent boot banner, revoke cleans disk token - W4: Brain stage enum sync, stepper advances to Add context, jobs collapsed - W5: index enrichment + skip UNINDEXED_* on PK/UK/TRUE_KEY - W3 thin: /onboarding routed + redirect when no connections; payload fix - W6: DeepSQL title, generic Agent suggestions, dbType canonicalize Co-authored-by: Venkat SF <venkatesh.sakamuri@stayflexi.com>
recordStageDetails only mutated the in-memory status handle; updateProgress reloads from DB and dropped SCHEMA_SCAN coverage metrics. Write merged stageDetails to the live row so W2b coverage is visible on init-status. Co-authored-by: Venkat SF <venkatesh.sakamuri@stayflexi.com>
Co-authored-by: Venkat SF <venkatesh.sakamuri@stayflexi.com>
Coverage gate can stop the pipeline at NEEDS_ATTENTION; without this, onboarding and init polls stay in "running" forever. Shared initStage helpers keep COMPLETED/FAILED/NEEDS_ATTENTION/ERROR consistent. Co-authored-by: Venkat SF <venkatesh.sakamuri@stayflexi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the minimum viable Sunday cut from
docs/oss-ux/E2E_FIX_PROPOSAL.md(PR #47 handoff), on top of latestmain(#44 agent container, #47 oss-ux docs).stageDetails(liveUserTableCount,coveragePercent,schemasScanned);NEEDS_ATTENTIONstagedeepsql.token+DEEPSQL_TOKEN_FILE; fail-loud provision; session MCP auth probe (mcpAuthOk); Agent boot banner; revoke clears disk tokenSTAGE_ORDERsynced toInitStage; stepper → Add context on complete; jobs collapsed; coverage line in UIUNINDEXED_*on PK/UK/TRUE_KEY/onboardingrouted; login redirect when no connections; wizard payload matchesConnectionRequestdbTypeDeferred: schema allow-list UI (W2c), fuller W7 smoke matrix, security S1–S5.
E2E results (Compose redeploy of this branch)
backend/frontend/deepsql-agente2e-agent-check.pyondemo_shop— AGENT_OK + DASH_OKcrm+sales: objects API returns 3 tables across both schemas; BrainSCHEMA_SCANreportsliveUserTableCount=3,coveragePercent=100,schemasScanned=['crm','sales']/onboarding→ HTTP 200POST /api/agent/sessionreturnsmcpAuthOk: trueafter login and after logout→login;deepsql.tokenpresent on agent profilePR tip:
c1b7504