feat: allow MCP admin CREATE/ALTER; keep DROP and TRUNCATE blocked - #82
Merged
Merged
Conversation
Coding agents were stuck on MCP's read-only query context. Admins can now run DML and non-destructive DDL through execute_sql with the existing confirmation and WHERE gates. DROP and TRUNCATE stay blocked on MCP even when confirmed; the SQL Editor still only blocks DROP TABLE. Co-authored-by: Venkat SF <venkatesh.sakamuri@stayflexi.com>
Mockito strict stubbing failed when ClientContext read other X-DeepSQL-* headers besides Authorization. Co-authored-by: Venkat SF <venkatesh.sakamuri@stayflexi.com>
venkateshsakamuri-lab
marked this pull request as ready for review
August 24, 2026 14:15
venkateshsakamuri-lab
requested review from
a team and
geekypunk
as code owners
August 24, 2026 14:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coding agents were blocked from DDL because MCP bearer SQL used a hard-coded read-only
QueryExecutionContext. Admins can now run DML and non-destructive DDL (CREATE,ALTER,CREATE INDEX) throughexecute_sql/deepsql querywith the same confirmation, privilege, and WHERE gates as the SQL Editor.DROPandTRUNCATEstay blocked on MCP and coding-agent loops even withconfirmMutation: true. The web SQL Editor is unchanged: it still blocks onlyDROP TABLE; other Editor DROPs andTRUNCATEremain confirm-gated.apply_index_recommendationis still the only MCP path that can drop an index (server-generated DDL).Policy
requiresConfirmationUNSAFE_MUTATION_BLOCKED)confirmMutation=trueChanges
QueryExecutionContext.mcp(...)isMAY_MUTATEfor admins and acceptsmutationConfirmedQueryExecutionPolicyServiceblocks MCPDROP*/TRUNCATE(including EXPLAIN-wrapped forms)SchemaControllerandExplainControllerpass MCP vs Editor origin plus confirmation throughforSqlSurface@deepsql/mcpbumped to0.28.0Testing
Backend unit tests (
QueryExecutionPolicyServiceTest,QueryExecutionContextTest,ExplainControllerPolicyTest,McpTokenServiceTest): 63 passed.MCP package:
npm test— 269 passed.Live against ACME ERP with an admin MCP token:
CREATE TABLE→EDITOR_MUTATION_CONFIRMATION_REQUIREDCREATE TABLE/ALTER TABLE/CREATE INDEX→ 200 successDROP TABLE/TRUNCATE/DROP INDEX→UNSAFE_MUTATION_BLOCKEDTRUNCATEandDROP INDEXstill succeed; EditorDROP TABLEstill blocked