Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Sindhi (PK) translation #627

Merged
merged 1 commit into from
Dec 21, 2023
Merged

feat: Added Sindhi (PK) translation #627

merged 1 commit into from
Dec 21, 2023

Conversation

Mariya-ghafoor
Copy link
Contributor

@Mariya-ghafoor Mariya-ghafoor commented Dec 21, 2023 •
edited
Loading

Description

The PR adds Sindhi (PK) translations to translations.php

Fixes # 236

Type of change

  • New feature (added a non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

Screenshot 2023-12-21 at 12 50 21 PM

@DenverCoder1 DenverCoder1 temporarily deployed to streak-stats-sd-pk-dngk9kxvgs9 December 21, 2023 10:45 Inactive
@DenverCoder1 DenverCoder1 changed the title Adds Sindhi (PK) translation feat: Added Sindhi (PK) translation Dec 21, 2023
DenverCoder1
DenverCoder1 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 merged commit 0046b71 into DenverCoder1:main Dec 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mariya-ghafoor @DenverCoder1