Skip to content

fix(mcp): report freshness with the indexer's own mtime source (#1714) - #1787

Open
umi008 wants to merge 1 commit into
DeusData:mainfrom
umi008:fix/issue-1714-freshness-mtime
Open

fix(mcp): report freshness with the indexer's own mtime source (#1714)#1787
umi008 wants to merge 1 commit into
DeusData:mainfrom
umi008:fix/issue-1714-freshness-mtime

Conversation

@umi008

@umi008 umi008 commented Aug 21, 2026

Copy link
Copy Markdown

What does this PR do?

check_index_coverage reported freshness: "metadata_changed" for every file on Windows, always — including files checked seconds after a successful full re-index. The freshness reader recomputed mtime_ns from struct stat (which on Windows truncates to seconds via st_mtime), while the indexer records the FILETIME-derived nanosecond value from cbm_path_info_utf8. A byte-identical file therefore never matched, so the freshness field carried no signal and agents following the documented guidance were told to distrust a graph that was actually current.

Both readers now compare against the same source the writer uses:

  • coverage_path_freshness (mcp.c) derives the comparison mtime/size from cbm_path_info_utf8 — the exact function the indexer records from — instead of a platform-dependent stat conversion. The Windows-only st_mtime truncation path is gone.
  • The same truncation existed in the pipeline's incremental change-detection (pipeline_incremental.c), where it would mark every file changed on Windows; it now uses cbm_path_info_utf8 too, on all platforms.

Checklist

  • Every commit is signed off (git commit -s) — required, CI rejects unsigned commits (DCO, see CONTRIBUTING.md)
  • Tests pass locally (make -f Makefile.cbm test)
  • Lint passes (make -f Makefile.cbm lint-ci)
  • New behavior is covered by a test (reproduce-first for bug fixes)

@umi008
umi008 requested a review from DeusData as a code owner August 21, 2026 19:53
@github-actions

Copy link
Copy Markdown

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

  • It will not be closed for inactivity. No stale bot touches pull requests here.
  • It may still sit a while before a human reads it. That is on us, not on you.
  • Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

  • Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
  • Get CI green, or say which failures you believe are pre-existing.
  • Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
  • Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

check_index_coverage freshness recomputed mtime_ns from struct stat, which
on Windows truncates to seconds, while the indexer records
cbm_path_info_utf8's FILETIME-derived nanosecond value. A byte-identical
file therefore never matched and every path was reported metadata_changed,
so the freshness field carried no signal on Windows.

The pipeline incremental change-detection had the same truncation in its
hash comparison. Both readers now compare against the same source the
writer uses.

Fixes DeusData#1714

Signed-off-by: Ulises Millan Guerrero <ulises.millanguerrero@gmail.com>
@umi008
umi008 force-pushed the fix/issue-1714-freshness-mtime branch from 07abd9b to 455e4fb Compare August 22, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant