-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shader cache polishing #748
Open
alichraghi
wants to merge
11
commits into
master
Choose a base branch
from
ali_shader_cache
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
01fff54
stash
alichraghi c1c4908
ShaderCompiler: Polishing
alichraghi e4636ba
ShaderCompiler: Remove comment
alichraghi d821878
use blake3_hash_t and std-specialization
alichraghi 8c70f06
fix serialization
alichraghi 99f9386
not working yet
alichraghi afa4935
maybe
alichraghi b2927ba
ready
alichraghi ff7ed06
review fixes
alichraghi 3445f61
resolve reviews
alichraghi f3961db
resolve reviews
alichraghi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you making a temp vector just to
memcpy
it later into aspirv
buffer?just make the buffer now and write into that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the final size after compression is unknown and
ICPUBuffer
can't be resized (unless you ask me to add aresize
method?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok didn't realize.
In that case, there's a thing called
CCPUBuffer
with a custom allocator that can also adopt memoryyou can
malloc
instead of having a vector, thenrealloc
and after realloc is complete you can create thatCCustomAllocatorCPUBuffer
withcore::adopt_memory
tag constructor overloadYou just need to provide an "allocator" which will call
free()
on the adopted pointerThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll address this in the upcoming Lib Shader Stage PR