Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use DEBUG flag instead of CI #358

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

simon-q
Copy link

@simon-q simon-q commented Apr 13, 2023

CI is set to true in CI/CD tools such as Bitbucket pipelines. That results in excessive debug log if pem library is used in scripts that run in CI/CD of other projects, e.g. when pem library is used in tests that are running in a Bitbucket pipeline.
It would be therefore better to use a different flag than CI to control when debug logs are produced. This PR suggests DEBUG flag.

@cernytomas
Copy link
Contributor

Hi @Dexus, could you please have a look?

@Dexus
Copy link
Owner

Dexus commented Aug 7, 2023

If you want to change it, the GitHub workflow should be considered as well. If the change is made, I can accept it.

@cernytomas
Copy link
Contributor

If you want to change it, the GitHub workflow should be considered as well. If the change is made, I can accept it.

I made requested changes #373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants