Added 'public client' & enhanced orders #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the end of client.py I've added some function definitions for more user-friendly order functionality to handle all the bs we've been dealing with (timestamps, storageID, etc.) I've also added a bunch of global functions that serve as a 'public client' where users can go to get public information without impacting their rate limit on the authenticated client. These are just a bunch of simple requests packaged as easy-to-use functions that return simple json data. More documentation needs to be added, as it will be copied from the REST api doc provided by loopring.
|
It could be worth using There's also the option to allow sync requests to execute concurrently by using asyncio's loop.run_in_executor(). Great functions though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the end of client.py I've added some function definitions for more user-friendly order functionality to handle all the bs we've been dealing with (timestamps, storageID, etc.)
I've also added a bunch of global functions that serve as a 'public client' where users can go to get public information without impacting their rate limit on the authenticated client. These are just a bunch of simple requests packaged as easy-to-use functions that return simple json data. More documentation needs to be added, as it will be copied from the REST api doc provided by loopring.