Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: pass props by passing props id #1658

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: pass props by passing props id #1658

wants to merge 1 commit into from

Conversation

swkatmask
Copy link
Contributor

@swkatmask swkatmask commented Jul 2, 2024 •
edited
Loading

Performance Improvement

  • Reuse the payload object
  • No JSON.stringify on big object or JSON.parse on large json
  • No extra memory allocation for a copy of payload for Mask side.
  • No large string in DOM or vDOM

@vercel Vercel
Copy link

vercel bot commented Jul 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firefly-mask-social ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 10:29am

@swkatmask swkatmask marked this pull request as ready for review July 2, 2024 14:19
@swkatmask swkatmask requested a review from guanbinrui July 3, 2024 08:26
@swkatmask swkatmask force-pushed the refactor/not-pass-props-directly branch from 57b4733 to b15ed23 Compare July 10, 2024 09:40
@swkatmask swkatmask force-pushed the refactor/not-pass-props-directly branch 2 times, most recently from fa1e133 to 63fd4ba Compare July 10, 2024 10:19
@swkatmask swkatmask force-pushed the refactor/not-pass-props-directly branch from 63fd4ba to 20880d0 Compare July 10, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guanbinrui guanbinrui Awaiting requested review from guanbinrui

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@swkatmask