fix: role errcheck issues (mattermost#28544)

Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Dithn · Oct 8, 2024 · 9d6adbf · 9d6adbf
1 parent 1d431e7
commit 9d6adbf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/server/.golangci.yml b/server/.golangci.yml
@@ -91,7 +91,6 @@ issues:
         channels/api4/preference_test.go|\
         channels/api4/reaction_test.go|\
         channels/api4/remote_cluster.go|\
-        channels/api4/role.go|\
         channels/api4/role_test.go|\
         channels/api4/saml.go|\
         channels/api4/scheme.go|\

diff --git a/server/channels/api4/role.go b/server/channels/api4/role.go
@@ -47,7 +47,10 @@ func getAllRoles(c *Context, w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	w.Write(js)
+	if _, err := w.Write(js); err != nil {
+		c.Logger.Warn("Error while writing response", mlog.Err(err))
+		return
+	}
 }
 
 func getRole(c *Context, w http.ResponseWriter, r *http.Request) {
@@ -119,7 +122,10 @@ func getRolesByNames(c *Context, w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	w.Write(js)
+	if _, err := w.Write(js); err != nil {
+		c.Logger.Warn("Error while writing response", mlog.Err(err))
+		return
+	}
 }
 
 func patchRole(c *Context, w http.ResponseWriter, r *http.Request) {