Fix errcheck issues in channels/app/admin_test.go (mattermost#28767)

Dithn · Oct 14, 2024 · ff6de4b · ff6de4b
1 parent a190fe8
commit ff6de4b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/server/.golangci.yml b/server/.golangci.yml
@@ -97,7 +97,6 @@ issues:
         channels/api4/webhook_test.go|\
         channels/api4/websocket_test.go|\
         channels/app/admin.go|\
-        channels/app/admin_test.go|\
         channels/app/app_test.go|\
         channels/app/authorization_test.go|\
         channels/app/auto_responder_test.go|\

diff --git a/server/channels/app/admin_test.go b/server/channels/app/admin_test.go
@@ -32,7 +32,8 @@ func TestGetLatestVersion(t *testing.T) {
 	require.NoError(t, jsonErr)
 
 	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		w.Write(validJSON)
+		_, err := w.Write(validJSON)
+		require.NoError(t, err)
 	}))
 	defer ts.Close()
 
@@ -62,7 +63,8 @@ func TestGetLatestVersion(t *testing.T) {
 		require.NoError(t, jsonErr)
 
 		updatedServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-			w.Write(updatedJSON)
+			_, err := w.Write(updatedJSON)
+			require.NoError(t, err)
 		}))
 		defer ts.Close()
 
@@ -76,11 +78,12 @@ func TestGetLatestVersion(t *testing.T) {
 		th.App.ClearLatestVersionCache(th.Context)
 		errorServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 			w.WriteHeader(http.StatusInternalServerError)
-			w.Write([]byte(`
+			_, err := w.Write([]byte(`
 				{
 					"message": "internal server error"
 				}
 			`))
+			require.NoError(t, err)
 		}))
 		defer ts.Close()