fix(ingress): normalize requirements file mode - #118
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is minimal, consistent with existing BuildKit-only Dockerfile usage, and directly addresses the reproducibility concern described in the PR.
Pull request overview
This PR makes the dstack-ingress image build more reproducible by ensuring requirements.txt always has consistent permissions inside the image, so the resulting image digest doesn’t vary based on the working tree’s file mode.
Changes:
- Normalize
requirements.txtpermissions duringCOPYusing--chmod=644. - Add an inline comment documenting why the normalization is needed for reproducible digests.
File summaries
| File | Description |
|---|---|
| custom-domain/dstack-ingress/Dockerfile | Ensures deterministic file mode for requirements.txt at build time to stabilize the resulting image digest. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requirements.txtto mode0644when copying it into the imageVerification
Built from a worktree where
requirements.txthad mode0664:This exactly matches the published
dstacktee/dstack-ingress:2.4digest.