-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new SOwISC12to30E3r3 ocean and sea-ice mesh #106
Add new SOwISC12to30E3r3 ocean and sea-ice mesh #106
Conversation
@jonbob and @darincomeau, the mesh is ready for some sanity checking and then making mapping files. |
@jonbob, apologies! @cbegeman asked me to make some changes to the mesh (to ensure a thicker minimum water-column thickness). I don't think those changes will affect the horizontal mesh but I am not sure that they won't. Even if the cell count with these changes happens to be the same, the cell order might be different. So if you happen to have started making mapping files, I'm afraid you'll need to start over. If you haven't had a chance to start yet, that would be a relief! |
2711605
to
3651c89
Compare
Are you all interested in any particular configurations? I've made mapping files for the following atm resolutions: |
That looks complete to me - thanks @jonbob ! |
I believe we're most interested in B-cases with the r05 try grid. We will probably use the JRA grid, too. But it's really good to have all those options. Thanks @jonbob! |
If we don't want to stage them all now, I agree with @xylar that |
I added support for G-case with T62 and TL319 configurations, as well as fully-coupled using ne30pg2 in both bi- and tri-grid. I've staged the necessary files on the local lcrc inputdata directory, and tested:
So it's ready for your testing. Please note I didn't make spunup IC files from a G-case for use in B-cases |
@jonbob, oh, dear. @darincomeau already found a problem with the horizontal mesh (a place where we need a critical passage to keep there from being a hole in the land ice). I have finally fixed the issue after 2 false starts. I am rebuilding all the SORRM r3 Compass files now. I will likely ping you tomorrow to make new mapping files (again!). I'm very sorry about that. |
@xylar -- no problem. Darin had warned me yesterday, so I didn't push more on it. And I always need the practice making mapping files! |
Oh, I doubt that! I bet you could make them in your sleep at this point. |
52b5ace
to
8bd2c5a
Compare
@darincomeau, if you happen to be working today, could you give the new version of the mesh a sanity check before @jonbob makes mapping files. I really want the 3rd time to be the charm here... |
|
Thanks @darincomeau!! |
I updated the mapping and domain files, and pushed the new file datestamps and mesh size to this PR. I have staged the files in the lcrc local inputdata directory for testing. I did successfully make the following cases:
|
Thanks so much @jonbob! I just updated the I'll rerun the 2 smoke tests you ran (or at least submitted) to make sure things are still fine, but I expect them to be. |
Yep, both tests passed for me:
|
Ok great, I'll get the G-case going |
Just fyi. I did make mapping files to support ne120_r025_SOwISC12to30E3r3 as well. Please let me know if you want to add this configuration to the PR |
@jonbob, if you've bothered to make the mapping files, I think it makes sense to add the configuration here as well. |
@darincomeau, thanks for adding the B-case initial conditions! Keep us posted on how the G-case goes. |
Looks like it'll still be in the queue for awhile. I also have a B-case sitting in the queue. It's a |
@darincomeau, do you know who to ask? We do probably want that. |
I think Wuyin? |
@xylar I don't understand what you mean because |
@cbegeman, my idea of setting I don't think we have a plausible method for reconstruction gradSSH at cell centers from a subset of edges, so we would need to create a value for gradSSH at all edges (including those bounded by land ice on one side and maybe even including open-ocean edges bounded on both sides by some fraction of land ice). I don't think there are any tricks we can use with the existing, very local vector reconstruction that would take care of this without some form of extrapolation of pressureAdjustedSSH or gradSSH. |
Yay. Nice find. |
@xylar Would it help me for to review the mesh once more with my script? I can set it running this morning. |
@proteanplanet, yes, I think it wouldn't hurt to rerun your script. I don't think much has changed but I also absolutely don't want to assume that. |
Fixes typo in PR #106 that accidentally got merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on test simulations here:
https://acme-climate.atlassian.net/wiki/spaces/OO/pages/4441145345/Review+SOwISC12to30E3r3
90d278e
to
9d7fbb1
Compare
@jonbob, let me know if this mesh is ready to go to E3SM from your perspective. |
I think @proteanplanet was about ready to sign off on this. We'd like to get it in for the new tag if possible. |
Please have this on next by Monday if you want it in the 3.0.1 tag. |
Closed in favor of E3SM-Project#6631 |
Rescinding this statement, not a priority for 3.0.1 |
Long name: SOwISC12to30kmL80E3SMv3r3
This version of the Southern Ocean Regionally Refined Mesh (SORRM) has resolution that is:
It is intended to be similar to the IcoswISC30E3r5 mesh except in the Southern Ocean and around Antarctica.
This is a proposed E3SM v3 (E3) mesh for polar (formerly cryosphere) simulations. This is revision 3 (r3) of the mesh, which includes many changes from revision 2 outlined in MPAS-Dev/compass#807. The mesh will be tagged as: https://github.com/MPAS-Dev/compass/releases/tag/mesh_SOwISC12to30E3r3 if it is accepted.
The mesh and the G-case results will be reviewed here:
https://acme-climate.atlassian.net/wiki/spaces/OO/pages/4441145345/Review+SOwISC12to30E3r3
A G- and B-case will begin shortly and analysis will be posted on the review page as soon as it is available.