-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix total land-ice freshwater flux in data mode #114
Fix total land-ice freshwater flux in data mode #114
Conversation
7ce3d1f
to
13b1062
Compare
Here is MPAS-Analysis from a 2-year G-case with DISMF: The total flux is no longer zero, as desired. The variability in time is due to frazil, and shows that it can be pretty significant: |
@darincomeau, anything you'd like to do to sanity-check this before it goes to E3SM? Since it's BFB, I think my 2-year test should be sufficient. But I could run a couple of B-case tests first to make sure it's really BFB as it should be. If you're okay with it, I'd do that once we move to E3SM, though. |
Also, do we need to add this to the BlueTip table? |
Thanks @xylar for the fix here! Do we know what happened where this functionality stopped working? In runs I had done earlier this year, DISMF was showing up as expected: |
@darincomeau, yes, @irenavankova figured out in her work that we were missing frazil in the total land-ice melt flux. She fixed that in E3SM in: I think we assumed that frazil would simply be disabled in cases with DISMF and didn't include it in the total but I think this approach is better. If frazil is disabled, the total is simply the same as the interface value and no special conditions are needed for plotting in MPAS-Anslysis. |
@xylar thanks for the fix! agree we can move this over to main repo. BFB tests against baselines with |
and yes we'll add this PR alongside the scaledDISMF PR in the SORRMv3 development table |
Previously, the total was only being computed when thermodynamics below ice shelves are actively computed, whereas we need to compute the total of the interface flux and the frazil flux when the interface flux comes from a data file as well. While we expect the frazil flux to be zero, these code modifications do not assume or require this to be true.
13b1062
to
40d5114
Compare
Closed in favor of E3SM-Project#6729 |
Previously, the total was only being computed when thermodynamics below ice shelves are actively computed, whereas we need to compute the total of the interface flux and the frazil flux when the interface flux comes from a data file as well. While we expect the frazil flux to be zero, these code modifications do not assume or require this to be true.
This PR addresses E3SM-Project#6719