Migration to Swift 4.2

ECLaboratorio · Sep 20, 2018 · 6a3d4e1 · 6a3d4e1
1 parent f83ca00
commit 6a3d4e1
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 7 deletions.
diff --git a/BubbleShowCase/BubbleShowCase.xcodeproj/project.pbxproj b/BubbleShowCase/BubbleShowCase.xcodeproj/project.pbxproj
@@ -283,7 +283,7 @@
 				PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
 				SKIP_INSTALL = YES;
 				SWIFT_OPTIMIZATION_LEVEL = "-Onone";
-				SWIFT_VERSION = 4.0;
+				SWIFT_VERSION = 4.2;
 				TARGETED_DEVICE_FAMILY = "1,2";
 			};
 			name = Debug;
@@ -309,7 +309,7 @@
 				PRODUCT_BUNDLE_IDENTIFIER = "com.elconfidencial.BubbleShowCase-iOS";
 				PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
 				SKIP_INSTALL = YES;
-				SWIFT_VERSION = 4.0;
+				SWIFT_VERSION = 4.2;
 				TARGETED_DEVICE_FAMILY = "1,2";
 			};
 			name = Release;

diff --git a/BubbleShowCase/BubbleShowCase/BubbleShowCase.podspec b/BubbleShowCase/BubbleShowCase/BubbleShowCase.podspec
@@ -1,7 +1,7 @@
 Pod::Spec.new do |s|
 
   s.name         = "BubbleShowCase"
-  s.version      = "1.0.0"
+  s.version      = "1.1.0"
   s.summary      = "A wonderful way to show case your users your App features"
 
   s.description  = <<-DESC
@@ -16,7 +16,7 @@ Pod::Spec.new do |s|
 
   s.platform     = :ios
   s.ios.deployment_target  = '9.0'
-  s.swift_version = '4.0'
+  s.swift_version = '4.2'
 
   s.source       = { :git => "https://github.com/ECLaboratorio/BubbleShowCase-iOS.git", :tag => "#{s.version}" }
   s.source_files  = "BubbleShowCase/BubbleShowCase/*.swift"

diff --git a/BubbleShowCase/BubbleShowCase/BubbleShowCase.swift b/BubbleShowCase/BubbleShowCase/BubbleShowCase.swift
@@ -491,7 +491,7 @@ public class BubbleShowCase: UIView {
 	private func setUp() {
 		currentOrientation = UIDevice.current.orientation
 		previousOrientation = currentOrientation
-		NotificationCenter.default.addObserver(self, selector: #selector(deviceDidRotate), name: .UIDeviceOrientationDidChange, object: nil)
+		NotificationCenter.default.addObserver(self, selector: #selector(deviceDidRotate), name: UIDevice.orientationDidChangeNotification, object: nil)
 	}
 
 	// Initializes the show case hierarchy and displays the show case into the screen.
@@ -537,7 +537,7 @@ public class BubbleShowCase: UIView {
 		alpha = 0
 		bubble.alpha = 0
 		screenshotContainer?.alpha = 0
-		screenWindow.bringSubview(toFront: self)
+		screenWindow.bringSubviewToFront(self)
 		UIView.animate(withDuration: showAnimationDuration, animations: { [weak self] in
 			self?.alpha = 1
 			self?.screenshotContainer?.alpha = 1

diff --git a/BubbleShowCase/BubbleShowCase/Info.plist b/BubbleShowCase/BubbleShowCase/Info.plist
@@ -15,7 +15,7 @@
 	<key>CFBundlePackageType</key>
 	<string>FMWK</string>
 	<key>CFBundleShortVersionString</key>
-	<string>0.0.4</string>
+	<string>1.1.0</string>
 	<key>CFBundleVersion</key>
 	<string>$(CURRENT_PROJECT_VERSION)</string>
 	<key>NSPrincipalClass</key>

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 Change Log
 ==========
+Version 1.1.0
+---
+* Migration to Swift 4.2
+
 Version 1.0.0
 ---
 * Releasing first version of the framework