Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the ReFrame tests at the end of the playbook #108

Merged
merged 9 commits into from
Jun 21, 2021

Conversation

bedroge
Copy link
Collaborator

@bedroge bedroge commented Jun 14, 2021

Tests will fail, first need a PR to fix and bump things for 2021.06 (coming soon...).

@bedroge bedroge mentioned this pull request Jun 16, 2021
12 tasks
@boegel
Copy link
Contributor

boegel commented Jun 19, 2021

CI doesn't actually fail at all, does that make sense?

@bedroge
Copy link
Collaborator Author

bedroge commented Jun 19, 2021

Ah, the ReFrame step actually failed:

TASK [compatibility_layer : Run ReFrame tests] *********************************
409
fatal: [127.0.0.1]: FAILED! => {"changed": false, "cmd": "reframe -r -v -c /tmp/compat_layer.py", "failed_when_result": true, "msg": "[Errno 2] No such file or directory: b'reframe'", "rc": 2}
410

But we run another command at the end of the action, which did succeed and changed the exit code to 0, so the action thinks it succeeded... I'll change that.

@boegel
Copy link
Contributor

boegel commented Jun 20, 2021

CI still passes 🤪

@bedroge
Copy link
Collaborator Author

bedroge commented Jun 20, 2021

Man, we really don't like passing tests, do we? :-D
I think I figured it out now, probably related to the rescue operation that should reraise the failure. Trying that now...

@bedroge
Copy link
Collaborator Author

bedroge commented Jun 21, 2021

CI is broken, see #111, let's fix that later... Tested this new functionality on a clean VM.

@boegel boegel merged commit 7f4e54e into EESSI:main Jun 21, 2021
@bedroge bedroge deleted the playbook_test_step branch June 21, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants