Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically redirect RISC-V users to riscv.eessi.io in init script + initial RISC-V support for archdetect #583

Merged
merged 5 commits into from
May 22, 2024

Conversation

bedroge
Copy link
Collaborator

@bedroge bedroge commented May 21, 2024

Tested on my Visionfive 2:

$ source /nvme/git/software-layer/init/bash 
RISC-V architecture detected, but there is no RISC-V support yet in the production repository.
Automatically switching to version 20240402 of the RISC-V development repository /cvmfs/riscv.eessi.io.
For more details about this repository, see https://www.eessi.io/docs/repositories/riscv.eessi.io/.

Found EESSI repo @ /cvmfs/riscv.eessi.io/versions/20240402!
archdetect says riscv64/generic
Using riscv64/generic as software subdirectory.
Found Lmod configuration file at /cvmfs/riscv.eessi.io/versions/20240402/software/linux/riscv64/generic/.lmod/lmodrc.lua
Found Lmod SitePackage.lua file at /cvmfs/riscv.eessi.io/versions/20240402/software/linux/riscv64/generic/.lmod/SitePackage.lua
Using /cvmfs/riscv.eessi.io/versions/20240402/software/linux/riscv64/generic/modules/all as the directory to be added to MODULEPATH.
Using /cvmfs/riscv.eessi.io/host_injections/20240402/software/linux/riscv64/generic/modules/all as the site extension directory to be added to MODULEPATH.
Initializing Lmod...
Prepending /cvmfs/riscv.eessi.io/versions/20240402/software/linux/riscv64/generic/modules/all to $MODULEPATH...
Prepending site path /cvmfs/riscv.eessi.io/host_injections/20240402/software/linux/riscv64/generic/modules/all to $MODULEPATH...
Environment set up to use EESSI (20240402), have fun!

And this is what archdetect reports:

$ /nvme/git/software-layer/init/eessi_archdetect.sh -d cpupath
2024-05-21 14:11:50 [DEBUG] cpupath: Override variable set as '' 
2024-05-21 14:11:50 [DEBUG] cpupath: Host CPU architecture identified as 'riscv64'
2024-05-21 14:11:50 [DEBUG] cpupath: CPU vendor of host system: ''
2024-05-21 14:11:50 [DEBUG] cpupath: CPU flags of host system: ''
2024-05-21 14:11:50 [INFO] cpupath: best match for host CPU: riscv64/generic
riscv64/generic

# the override still works:
$ env EESSI_SOFTWARE_SUBDIR_OVERRIDE=riscv64/visionfive2 /nvme/git/software-layer/init/eessi_archdetect.sh -d cpupath
2024-05-21 14:12:16 [DEBUG] cpupath: Override variable set as 'riscv64/visionfive2' 
riscv64/visionfive2

Copy link

eessi-bot bot commented May 21, 2024

Instance eessi-bot-mc-aws is configured to build:

  • arch x86_64/generic for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/generic for repo eessi-hpc.org-2023.06-software
  • arch x86_64/generic for repo eessi.io-2023.06-compat
  • arch x86_64/generic for repo eessi.io-2023.06-software
  • arch x86_64/intel/haswell for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/intel/haswell for repo eessi-hpc.org-2023.06-software
  • arch x86_64/intel/haswell for repo eessi.io-2023.06-compat
  • arch x86_64/intel/haswell for repo eessi.io-2023.06-software
  • arch x86_64/intel/skylake_avx512 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/intel/skylake_avx512 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/intel/skylake_avx512 for repo eessi.io-2023.06-compat
  • arch x86_64/intel/skylake_avx512 for repo eessi.io-2023.06-software
  • arch x86_64/amd/zen2 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/amd/zen2 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/amd/zen2 for repo eessi.io-2023.06-compat
  • arch x86_64/amd/zen2 for repo eessi.io-2023.06-software
  • arch x86_64/amd/zen3 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/amd/zen3 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/amd/zen3 for repo eessi.io-2023.06-compat
  • arch x86_64/amd/zen3 for repo eessi.io-2023.06-software
  • arch aarch64/generic for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/generic for repo eessi-hpc.org-2023.06-software
  • arch aarch64/generic for repo eessi.io-2023.06-compat
  • arch aarch64/generic for repo eessi.io-2023.06-software
  • arch aarch64/neoverse_n1 for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/neoverse_n1 for repo eessi-hpc.org-2023.06-software
  • arch aarch64/neoverse_n1 for repo eessi.io-2023.06-compat
  • arch aarch64/neoverse_n1 for repo eessi.io-2023.06-software
  • arch aarch64/neoverse_v1 for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/neoverse_v1 for repo eessi-hpc.org-2023.06-software
  • arch aarch64/neoverse_v1 for repo eessi.io-2023.06-compat
  • arch aarch64/neoverse_v1 for repo eessi.io-2023.06-software

Copy link

eessi-bot bot commented May 21, 2024

Instance eessi-bot-mc-azure is configured to build:

  • arch x86_64/amd/zen4 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/amd/zen4 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/amd/zen4 for repo eessi.io-2023.06-compat
  • arch x86_64/amd/zen4 for repo eessi.io-2023.06-software

ocaisa
ocaisa previously approved these changes May 21, 2024
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

boegel
boegel previously approved these changes May 21, 2024
Copy link
Contributor

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ocaisa
Copy link
Member

ocaisa commented May 21, 2024

bot: build repo:eessi.io-2023.06-software arch:x86_64/generic

Copy link

eessi-bot bot commented May 21, 2024

Updates by the bot instance eessi-bot-mc-aws (click for details)

Copy link

eessi-bot bot commented May 21, 2024

Updates by the bot instance eessi-bot-mc-azure (click for details)
  • received bot command build repo:eessi.io-2023.06-software arch:x86_64/generic from ocaisa

    • expanded format: build repository:eessi.io-2023.06-software architecture:x86_64/generic
  • handling command build repository:eessi.io-2023.06-software architecture:x86_64/generic resulted in:

    • no jobs were submitted

Copy link

eessi-bot bot commented May 21, 2024

New job on instance eessi-bot-mc-aws for architecture x86_64-generic for repository eessi.io-2023.06-software in job dir /project/def-users/SHARED/jobs/2024.05/pr_583/11162

date job status comment
May 21 14:50:28 UTC 2024 submitted job id 11162 awaits release by job manager
May 21 14:51:21 UTC 2024 released job awaits launch by Slurm scheduler
May 21 15:59:29 UTC 2024 running job 11162 is running
May 21 16:04:34 UTC 2024 finished
😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-11162.out
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.gz created!
Artefacts
eessi-2023.06-software-linux-x86_64-generic-1716307147.tar.gzsize: 0 MiB (3246 bytes)
entries: 3
modules under 2023.06/software/linux/x86_64/generic/modules/all
no module files in tarball
software under 2023.06/software/linux/x86_64/generic/software
no software packages in tarball
other under 2023.06/software/linux/x86_64/generic
2023.06/init/eessi_archdetect.sh
2023.06/init/eessi_defaults
2023.06/init/minimal_eessi_env
May 21 16:04:34 UTC 2024 test result
😁 SUCCESS (click triangle for details)
ReFrame Summary
[ PASSED ] Ran 10/10 test case(s) from 10 check(s) (0 failure(s), 0 skipped, 0 aborted)
Details
✅ job output file slurm-11162.out
✅ no message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case
May 21 20:22:32 UTC 2024 uploaded transfer of eessi-2023.06-software-linux-x86_64-generic-1716307147.tar.gz to S3 bucket succeeded

@ocaisa
Copy link
Member

ocaisa commented May 21, 2024

@bedroge I'm waiting ages for both the bot and GitHub Actions, guess we have some GitHub issues

@boegel
Copy link
Contributor

boegel commented May 21, 2024

@ocaisa Looks good now?

@ocaisa ocaisa added bot:deploy Ask bot to deploy missing software installations to EESSI and removed bot:deploy Ask bot to deploy missing software installations to EESSI labels May 21, 2024
@ocaisa
Copy link
Member

ocaisa commented May 21, 2024

@bedroge it's missing the updates to the arch_spec folder

@bedroge
Copy link
Collaborator Author

bedroge commented May 21, 2024

@bedroge it's missing the updates to the arch_spec folder

Which updates do you mean? It does contain the (almost empty) spec file for RISC-V?

@ocaisa
Copy link
Member

ocaisa commented May 21, 2024

In the report from the bot I only see

other under 2023.06/software/linux/x86_64/generic
2023.06/init/eessi_archdetect.sh
2023.06/init/eessi_defaults
2023.06/init/minimal_eessi_env

@bedroge
Copy link
Collaborator Author

bedroge commented May 21, 2024

In the report from the bot I only see

other under 2023.06/software/linux/x86_64/generic
2023.06/init/eessi_archdetect.sh
2023.06/init/eessi_defaults
2023.06/init/minimal_eessi_env

Ah, you mean the tarball. Yes, you're right, I just checked the tarball itself and it doesn't contain it... let me check.

edit: found it, it has to be added to install_scripts.sh.

@bedroge bedroge dismissed stale reviews from boegel and ocaisa via 84036fa May 21, 2024 21:06
@bedroge
Copy link
Collaborator Author

bedroge commented May 21, 2024

bot: build repo:eessi.io-2023.06-software arch:x86_64/generic

Copy link

eessi-bot bot commented May 21, 2024

Updates by the bot instance eessi-bot-mc-aws (click for details)

Copy link

eessi-bot bot commented May 21, 2024

Updates by the bot instance eessi-bot-mc-azure (click for details)
  • received bot command build repo:eessi.io-2023.06-software arch:x86_64/generic from bedroge

    • expanded format: build repository:eessi.io-2023.06-software architecture:x86_64/generic
  • handling command build repository:eessi.io-2023.06-software architecture:x86_64/generic resulted in:

    • no jobs were submitted

Copy link

eessi-bot bot commented May 21, 2024

New job on instance eessi-bot-mc-aws for architecture x86_64-generic for repository eessi.io-2023.06-software in job dir /project/def-users/SHARED/jobs/2024.05/pr_583/11163

date job status comment
May 21 21:06:46 UTC 2024 submitted job id 11163 awaits release by job manager
May 21 21:07:00 UTC 2024 released job awaits launch by Slurm scheduler
May 21 22:10:07 UTC 2024 running job 11163 is running
May 21 22:15:12 UTC 2024 finished
😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-11163.out
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.gz created!
Artefacts
eessi-2023.06-software-linux-x86_64-generic-1716329361.tar.gzsize: 0 MiB (3307 bytes)
entries: 4
modules under 2023.06/software/linux/x86_64/generic/modules/all
no module files in tarball
software under 2023.06/software/linux/x86_64/generic/software
no software packages in tarball
other under 2023.06/software/linux/x86_64/generic
2023.06/init/arch_specs/eessi_arch_riscv.spec
2023.06/init/eessi_archdetect.sh
2023.06/init/eessi_defaults
2023.06/init/minimal_eessi_env
May 21 22:15:12 UTC 2024 test result
😁 SUCCESS (click triangle for details)
ReFrame Summary
[ PASSED ] Ran 10/10 test case(s) from 10 check(s) (0 failure(s), 0 skipped, 0 aborted)
Details
✅ job output file slurm-11163.out
✅ no message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case
May 22 05:18:20 UTC 2024 uploaded transfer of eessi-2023.06-software-linux-x86_64-generic-1716329361.tar.gz to S3 bucket succeeded

@ocaisa ocaisa added the bot:deploy Ask bot to deploy missing software installations to EESSI label May 22, 2024
@ocaisa ocaisa merged commit c635420 into EESSI:2023.06-software.eessi.io May 22, 2024
36 checks passed
@bedroge bedroge deleted the init_redirect_riscv branch May 22, 2024 06:11
@boegel boegel added the riscv label May 24, 2024
@boegel boegel added the 2023.06-software.eessi.io 2023.06 version of software.eessi.io label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023.06-software.eessi.io 2023.06 version of software.eessi.io bot:deploy Ask bot to deploy missing software installations to EESSI riscv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants