Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove tryCatch() that hides the error message #161

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Feb 28, 2024

I noticed that the tryCatch() did not work because the error condition does not have access to service_url. Furthermore, what was needed for me was the actual error. So I propose removing check_service() and instead document the existence of the monitor.

Note the builds won't pass until #159 or another fix is merged.

@salvafern
Copy link
Collaborator

Hi @maelle , I believe we will be loosing some nice error messages as well (e.g. no internet). But surfacing other error messages is also a good idea. I agree but maybe would be good a quick review by @annakrystalli ?

@maelle
Copy link
Collaborator Author

maelle commented Mar 5, 2024

I can see that but at the same time, if one doesn't have an internet connection, it's easy to notice even without R? 🤔

@salvafern
Copy link
Collaborator

fair enough :)

@maelle maelle merged commit c7e4cc8 into main Mar 15, 2024
6 of 7 checks passed
@maelle maelle deleted the tries branch March 15, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants