refactor: cleanup code

ERC725Alliance · Apr 25, 2024 · 5af2f58 · 5af2f58
1 parent 3e6213a
commit 5af2f58
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/src/index.test.ts b/src/index.test.ts
@@ -939,10 +939,6 @@ describe('Running @erc725/erc725.js tests...', () => {
     });
   });
 
-  describe('Testing `decodeData`', () => {
-    // ...
-  });
-
   describe('Testing utility encoding & decoding functions', () => {
     const allGraphData = generateAllData(mockSchema) as any;
     /* **************************************** */

diff --git a/src/lib/encoder.test.ts b/src/lib/encoder.test.ts
@@ -321,7 +321,7 @@ describe('encoder', () => {
       ];
 
       leftPaddedTestCases.forEach((testCase) => {
-        it(`encodes + left pad \`input\` = ${testCase.input} as ${testCase.valueType} padded on the right with \`00\`s`, async () => {
+        it(`encodes + left pad number \`input\` = ${testCase.input} as ${testCase.valueType} padded on the left with \`00\`s`, async () => {
           const encodedValue = encodeValueType(
             testCase.valueType,
             testCase.input,

diff --git a/src/lib/encoder.ts b/src/lib/encoder.ts
@@ -219,7 +219,9 @@ const encodeToBytesN = (
     // if we receive a plain string (e.g: "hey!"), convert it to utf8-hex data
     valueToEncode = toHex(value);
   } else if (typeof value === 'number') {
-    // if we receive a number as input, convert it to hex, left padded
+    // if we receive a number as input, convert it to hex,
+    // despite `bytesN` pads on the right, we pad number on the left side here
+    // to symmetrically encode / decode
     valueToEncode = padLeft(numberToHex(value), numberOfBytesInType * 2);
   } else {
     valueToEncode = value;