-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Create release #377
Closed
Closed
fix: Create release #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Add workaround to read (bytes4,URI), repair unknown signature to pass.
…cessible withing getDataFromExternalSources.
fix: Make data retrieval more resilient. Do not throw on ipfs data problems.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
- Coverage 83.18% 82.86% -0.33%
==========================================
Files 19 19
Lines 1231 1243 +12
Branches 282 286 +4
==========================================
+ Hits 1024 1030 +6
- Misses 110 115 +5
- Partials 97 98 +1 ☔ View full report in Codecov by Sentry. |
feat: add permission related to 4337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
Make library more resilient to read data that's not 100% correctly formatted.
What is the current behaviour (you can also link to an open issue here)?
Currently getData sometimes causes and exception even though it could read the data.
Currently getData throws exceptions rather than just returning null.
What is the new behaviour (if this is a feature change)?
It's more resilient.
Other information: