Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create release #377

Closed
wants to merge 16 commits into from
Closed

fix: Create release #377

wants to merge 16 commits into from

Conversation

richtera
Copy link
Collaborator

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

Make library more resilient to read data that's not 100% correctly formatted.

What is the current behaviour (you can also link to an open issue here)?

Currently getData sometimes causes and exception even though it could read the data.
Currently getData throws exceptions rather than just returning null.

What is the new behaviour (if this is a feature change)?

It's more resilient.

Other information:

@codecov-commenter
Copy link

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (330c604) 83.18% compared to head (5709e2c) 82.86%.
Report is 52 commits behind head on main.

Files Patch % Lines
src/lib/encoder.ts 38.46% 4 Missing and 4 partials ⚠️
src/lib/getDataFromExternalSources.ts 16.66% 3 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
- Coverage   83.18%   82.86%   -0.33%     
==========================================
  Files          19       19              
  Lines        1231     1243      +12     
  Branches      282      286       +4     
==========================================
+ Hits         1024     1030       +6     
- Misses        110      115       +5     
- Partials       97       98       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richtera richtera closed this Jan 16, 2024
@richtera richtera deleted the fix/create-release branch January 16, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants