fix: decoding tuple when no value is fetched #380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #380 +/- ##
===========================================
+ Coverage 82.86% 83.58% +0.72%
===========================================
Files 19 19
Lines 1243 1243
Branches 286 286
===========================================
+ Hits 1030 1039 +9
+ Misses 115 110 -5
+ Partials 98 94 -4 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Felix Hildebrandt <fhildeb@users.noreply.github.com>
CJ42
force-pushed
the
fix/dynamic-key-fetch
branch
from
067feef
to
6b0ab14
Compare
|
Closing as this was already resolved in #378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
Bug fix
What is the current behaviour (you can also link to an open issue here)?
See issue #372
What is the new behaviour (if this is a feature change)?
When using
getDataorfetchDatawith a key type that contains a tuple, if no value is fetched, return an array with a number ofundefinedelements (as many as defined by the number of elements in the tuple).Other information:
Fix #372