-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Filter out ALL_PERMISSIONS from keys in LSP6_DEFAULT_PERMISSIONS. #409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove biome from this PR, and put it in a separate PR please?
Otherwise the PR is really hard to review as there are too many changes and I can't filter out what is related to the permissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are a lot of style changes here are the real changes.
6ec3e2b
to
549dfb5
Compare
I removed import sorting, so now only the cleanup and fixes are there. |
88fd894
to
d439e42
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #409 +/- ##
===========================================
- Coverage 83.71% 81.89% -1.83%
===========================================
Files 18 22 +4
Lines 1130 1364 +234
Branches 255 310 +55
===========================================
+ Hits 946 1117 +171
- Misses 98 138 +40
- Partials 86 109 +23 ☔ View full report in Codecov by Sentry. |
5ea6e3a
to
24bda3a
Compare
f52f1cf
to
cc31b5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some review comments. Otherwise some nice cleanups here! 🙌
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
Filter out keys from LSP6_DEFAULT_PERMISSIONS because it now has ALL_PERMISSIONS.
Having ALL_PERMISSIONS set during encodePermissions will always return ALL_PERMISSIONS.
Currently calling decodePermissions will always return ALL_PERMISSIONS on.
What is the current behaviour (you can also link to an open issue here)?
What is the new behaviour (if this is a feature change)?
Other information: