-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add processing selectors and tests. #75
Merged
prusse-martin
merged 24 commits into
ESSS:master
from
allanleal:add-conda-build-preprocessing-selectors-support
Feb 14, 2019
Merged
Changes from 13 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
9d600cb
Add processing selectors and tests.
allanleal 8c6ecee
Fix mocking of python functions.
allanleal 10512bd
Add back deleted key-value pairs by mistake.
allanleal 4db7701
[skip ci] Delete a blank line.
allanleal e5fe7c5
Remove py py2k, py3k, and use mock with lambda.
allanleal 751a31b
Add forgotten lambda functions!
allanleal bf1a366
Remove unused variable pyversion.
allanleal e5999d4
Fix lambda - need return of a tuple
allanleal ebb387f
Update usage docs.
allanleal 20e1f8d
Further improvements.
allanleal 87b3c0a
Remove command role.
allanleal ba1e330
Missing ``
allanleal 9bdf187
Using table as in conda-build docs
allanleal 14c495a
Add sphinx_rtd_theme dependency
allanleal 9376f81
Set sphinx_rdt_theme as the theme for docs.
allanleal 675d536
Add an overview of conda-devenv before contents section.
allanleal dad5aac
Adapt the existing example and add table with new variables.
allanleal 8a29ad7
Revert back changes in theme made for local testing.
allanleal 065e585
Remove some variables related to arm platforms.
allanleal 135f528
Remove some variables related to arm platforms.
allanleal 6d3fea2
Merge branch 'add-conda-build-preprocessing-selectors-support' of git…
allanleal d82c101
Remove non implemented tests.
allanleal 3304d4a
Revert sphinx theme to sphinx
allanleal e393996
Fix pygments_style and html_theme back to original
allanleal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to let those with
None
? I see you didn't add them to the docs.Could you remove them? And maybe create a issue do add them later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll see if I add them still in this PR. Before merging, I'll make a last call for approval just to be sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up deleting those three variables with None and entering a new Issue - #77 .