Skip to content

Make etl_profile Incompatible by Default - #1535

Open
christophruethingbmw wants to merge 3 commits into
ETLCPP:masterfrom
christophruethingbmw:patch-1
Open

Make etl_profile Incompatible by Default#1535
christophruethingbmw wants to merge 3 commits into
ETLCPP:masterfrom
christophruethingbmw:patch-1

Conversation

@christophruethingbmw

Copy link
Copy Markdown
Collaborator

At the moment for Bazel when using the etl library it by default uses the NO_PROFILE. This can be dangerous since consumers might accidently fall back to this default. Therefore, this change makes the default incompatible, in case a consumer wants to use the NO_PROFILE that's possible by using the still existing no_profile library target.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: bb22b17d-669f-4141-a271-265329314e58

📥 Commits

Reviewing files that changed from the base of the PR and between 7f29036 and 23be852.

📒 Files selected for processing (2)
  • .github/workflows/bazel-gcc-c++23-no-stl.yml
  • BUILD.bazel
🚧 Files skipped from review as they are similar to previous changes (2)
  • BUILD.bazel
  • .github/workflows/bazel-gcc-c++23-no-stl.yml

Walkthrough

The etl_profile Bazel label flag now defaults to incompatible_profile instead of no_profile. The new target is incompatible with all platforms. The CI build and test commands explicitly select no_profile. The test command continues to use full test output.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states that etl_profile defaults to an incompatible profile, matching the main change.
Description check ✅ Passed The description explains the risk of the NO_PROFILE default and how consumers can still select no_profile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@rolandreichweinbmw

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants