Make etl_profile Incompatible by Default - #1535
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1dce046 to
23be852
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
This comment was marked as outdated.
This comment was marked as outdated.
23be852 to
7570d16
Compare
At the moment for Bazel when using the
etllibrary it by default uses theNO_PROFILE. This can be dangerous since consumers might accidently fall back to this default. Therefore, this change makes the default incompatible, in case a consumer wants to use theNO_PROFILEthat's possible by using the still existingno_profilelibrary target.