Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: correct include order #715

Merged
merged 1 commit into from
Jun 11, 2024
Merged

refactor: correct include order #715

merged 1 commit into from
Jun 11, 2024

Conversation

a-w50
Copy link
Contributor

@a-w50 a-w50 commented Jun 10, 2024

  • delete unnecessary redefinition of UINT32_MAX
  • group and sort include files

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@a-w50
Copy link
Contributor Author

a-w50 commented Jun 11, 2024

Just saw, that #711 tries to fix the same issue. I would still propose, that we should include cstdint, as UINT32_MAX is defined in there. Furthermore, I rearranged/regrouped the includes

Copy link
Contributor

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

- delete unnecessary redefinition of UINT32_MAX
- group and sort include files

Signed-off-by: aw <aw@pionix.de>
@a-w50 a-w50 merged commit cc014c2 into main Jun 11, 2024
6 checks passed
@a-w50 a-w50 deleted the refactor/include_order branch June 11, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants