Refactor run-nodered script #816

andistorm · 2024-08-06T06:31:23Z

Describe your changes

Use docker volume to mount nodered config
Use nodered image from everest-dev-environment

Issue ticket number and link

Refactor: Clean up docker images EVerest#178

Checklist before requesting a review

I have performed a self-review of my code
I have made corresponding changes to the documentation
I read the contribution documentation and made sure that my changes meet its requirements

Requires

Refactor docker images in EVerest everest-dev-environment#45

cmake/assets/run_nodered_template.sh.in

Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>

cmake/assets/run_nodered_template.sh.in

Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>

cmake/assets/run_nodered_template.sh.in

a-w50 · 2024-10-10T09:42:29Z

cmake/assets/run_nodered_template.sh.in

+# allow starting the nodered container from inside a devcontainer
+
+# Create docker volume to contain nodered config
+docker volume create nodered-config-volume


nodered-config-volume is quite generic, not sure if it might collide with other node red instances. Would it be possible to use a local path inside build for example which gets mounted into the container instead of an volume. This would also ease the access to the config file.

This is more or less the way how the script worked before, I changed it to be able to start this container from inside a devcontainer, see below.

I changed the name of the volume and temporarily container to have a prefix everest-

a-w50 · 2024-10-10T09:43:53Z

cmake/assets/run_nodered_template.sh.in

+# In the following a volume is created to contain the nodered config, this is done to
+# allow starting the nodered container from inside a devcontainer


Why does using a volume allow to start the node-red container from inside a dev container?

The workspace inside the devcontainer is mounted to an other path. So you would need to know about the host path of the flow file.

docker run is executed on host with host paths

docker cp is executed with container's paths

This way it is possible to copy a file with only knowing the devcontainer paths into a docker volume which then can be mounted by name into the nodered container

I see, well this is really ugly. These docker inside docker scenarios are quite special, not sure whether we should support these - they might break quite easily. This script here basically only works, if the devcontainer has been launched correctly - which is an assumption I wouldn't necessarily make.
Does this script work, when executed from the host (i.e. outside of the container?)

It is not real docker inside docker, because it is more like remote controlling the hosts docker socket.
This script is designed to work inside and outside the devcontainer. Of course it needs to be rebuild when changed because of paths

cmake/assets/run_nodered_template.sh.in

Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>

hikinggrass · 2024-10-21T20:23:06Z

I'm getting the following error when running a nodered runscript (in this case ./build/run-scripts/nodered-sil-two-evse.sh) after a fresh build from this branch:

Status: Downloaded newer image for ghcr.io/everest/everest-dev-environment/nodered:docker-images-v0.1.0

> node-red-docker@2.2.3 start /usr/src/node-red
> node $NODE_OPTIONS node_modules/node-red/red.js $FLOWS "--userDir" "/data"

internal/fs/utils.js:332
    throw err;
    ^

Error: EACCES: permission denied, copyfile '/usr/src/node-red/node_modules/node-red/settings.js' -> '/data/settings.js'
    at Object.copyFileSync (fs.js:2062:3)
    at copyFile (/usr/src/node-red/node_modules/fs-extra/lib/copy-sync/copy-sync.js:70:6)
    at onFile (/usr/src/node-red/node_modules/fs-extra/lib/copy-sync/copy-sync.js:56:25)
    at getStats (/usr/src/node-red/node_modules/fs-extra/lib/copy-sync/copy-sync.js:48:44)
    at handleFilterAndCopy (/usr/src/node-red/node_modules/fs-extra/lib/copy-sync/copy-sync.js:33:10)
    at Object.copySync (/usr/src/node-red/node_modules/fs-extra/lib/copy-sync/copy-sync.js:26:10)
    at Object.<anonymous> (/usr/src/node-red/node_modules/node-red/red.js:129:20)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32) {
  errno: -13,
  syscall: 'copyfile',
  code: 'EACCES',
  path: '/usr/src/node-red/node_modules/node-red/settings.js',
  dest: '/data/settings.js'
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! node-red-docker@2.2.3 start: `node $NODE_OPTIONS node_modules/node-red/red.js $FLOWS "--userDir" "/data"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the node-red-docker@2.2.3 start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>

andistorm · 2024-10-28T08:16:44Z

I'm getting the following error when running a nodered runscript (in this case ./build/run-scripts/nodered-sil-two-evse.sh) after a fresh build from this branch:

Status: Downloaded newer image for ghcr.io/everest/everest-dev-environment/nodered:docker-images-v0.1.0

> node-red-docker@2.2.3 start /usr/src/node-red
> node $NODE_OPTIONS node_modules/node-red/red.js $FLOWS "--userDir" "/data"

internal/fs/utils.js:332
    throw err;
    ^

Error: EACCES: permission denied, copyfile '/usr/src/node-red/node_modules/node-red/settings.js' -> '/data/settings.js'
    at Object.copyFileSync (fs.js:2062:3)
    at copyFile (/usr/src/node-red/node_modules/fs-extra/lib/copy-sync/copy-sync.js:70:6)
    at onFile (/usr/src/node-red/node_modules/fs-extra/lib/copy-sync/copy-sync.js:56:25)
    at getStats (/usr/src/node-red/node_modules/fs-extra/lib/copy-sync/copy-sync.js:48:44)
    at handleFilterAndCopy (/usr/src/node-red/node_modules/fs-extra/lib/copy-sync/copy-sync.js:33:10)
    at Object.copySync (/usr/src/node-red/node_modules/fs-extra/lib/copy-sync/copy-sync.js:26:10)
    at Object.<anonymous> (/usr/src/node-red/node_modules/node-red/red.js:129:20)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32) {
  errno: -13,
  syscall: 'copyfile',
  code: 'EACCES',
  path: '/usr/src/node-red/node_modules/node-red/settings.js',
  dest: '/data/settings.js'
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! node-red-docker@2.2.3 start: `node $NODE_OPTIONS node_modules/node-red/red.js $FLOWS "--userDir" "/data"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the node-red-docker@2.2.3 start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

I added comamnd to set the UID and GID of the docker volume, could you try again pelase?

hikinggrass · 2024-10-29T10:33:34Z

I added comamnd to set the UID and GID of the docker volume, could you try again pelase?

This seems to have fixed it 👍

andistorm self-assigned this Aug 6, 2024

andistorm requested review from hikinggrass, a-w50, corneliusclaussen and Pietfried as code owners August 6, 2024 06:31

andistorm marked this pull request as draft August 6, 2024 06:31

a-w50 approved these changes Aug 7, 2024

View reviewed changes

cmake/assets/run_nodered_template.sh.in Outdated Show resolved Hide resolved

andistorm added 2 commits October 7, 2024 11:55

Refactor run-nodered script

c6e6508

Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>

Add comments to the nodered script

d3a67c0

Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>

andistorm force-pushed the refactor/run-nodered-script branch from 488dcfa to d3a67c0 Compare October 7, 2024 10:03

andistorm marked this pull request as ready for review October 7, 2024 10:03

andistorm assigned hikinggrass and Pietfried and unassigned andistorm Oct 7, 2024

hikinggrass requested changes Oct 7, 2024

View reviewed changes

cmake/assets/run_nodered_template.sh.in Outdated Show resolved Hide resolved

andistorm mentioned this pull request Oct 8, 2024

[node-red-node-ui-table] Node module cannot be loaded on this version. Requires: >=3.0.0 EVerest/everest-dev-environment#49

Closed

andistorm added 2 commits October 8, 2024 11:52

Use debian:12-slim as temporarily container image

439cfa1

Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>

Merge branch 'main' into refactor/run-nodered-script

d18da86

a-w50 reviewed Oct 10, 2024

View reviewed changes

hikinggrass approved these changes Oct 10, 2024

View reviewed changes

andistorm mentioned this pull request Oct 11, 2024

Pin node-red-node-ui-table to 0.4.3 in Dockerfile #895

Closed

2 tasks

hikinggrass requested changes Oct 17, 2024

View reviewed changes

cmake/assets/run_nodered_template.sh.in Outdated Show resolved Hide resolved

andistorm linked an issue Oct 21, 2024 that may be closed by this pull request

Node version error for Node-red UI table for nodered-sil.sh script #922

Closed

andistorm added 3 commits October 21, 2024 12:36

update tag

796e0e1

Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>

Add prefix

ed71995

Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>

Merge branch 'main' into refactor/run-nodered-script

d7ddd8d

set group and owner of docker volume

14ca168

Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>

andistorm closed this Oct 28, 2024

andistorm reopened this Oct 28, 2024

Merge branch 'main' into refactor/run-nodered-script

3de153e

hikinggrass approved these changes Oct 29, 2024

View reviewed changes

Merge branch 'main' into refactor/run-nodered-script

e82d5ad

Pietfried merged commit 55fbf4d into main Oct 30, 2024
10 checks passed

Pietfried deleted the refactor/run-nodered-script branch October 30, 2024 10:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor run-nodered script #816

Refactor run-nodered script #816

andistorm commented Aug 6, 2024 •

edited

Loading

a-w50 Oct 10, 2024

andistorm Oct 21, 2024

a-w50 Oct 10, 2024

andistorm Oct 21, 2024

a-w50 Oct 21, 2024

andistorm Oct 28, 2024

hikinggrass commented Oct 21, 2024

andistorm commented Oct 28, 2024

hikinggrass commented Oct 29, 2024

		# In the following a volume is created to contain the nodered config, this is done to
		# allow starting the nodered container from inside a devcontainer

Refactor run-nodered script #816

Refactor run-nodered script #816

Conversation

andistorm commented Aug 6, 2024 • edited Loading

Describe your changes

Issue ticket number and link

Checklist before requesting a review

Requires

a-w50 Oct 10, 2024

Choose a reason for hiding this comment

andistorm Oct 21, 2024

Choose a reason for hiding this comment

a-w50 Oct 10, 2024

Choose a reason for hiding this comment

andistorm Oct 21, 2024

Choose a reason for hiding this comment

a-w50 Oct 21, 2024

Choose a reason for hiding this comment

andistorm Oct 28, 2024

Choose a reason for hiding this comment

hikinggrass commented Oct 21, 2024

andistorm commented Oct 28, 2024

hikinggrass commented Oct 29, 2024

andistorm commented Aug 6, 2024 •

edited

Loading