Add simple EvAPI and extend EvManager with simplistic SoC calculation #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusclaussen
force-pushed
the
feature/ev-api
branch
from
7ae8d8d
to
bc64cb7
Compare
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
corneliusclaussen
force-pushed
the
feature/ev-api
branch
from
bc64cb7
to
b7a727d
Compare
…nnectors" This allows both the API and EvAPI modules to run simultaneously Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
This allows an EV implementation to report more detailed information such as SoC Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
hikinggrass
requested review from
SebaLukas,
Pietfried,
MarzellT and
corneliusclaussen
as code owners
|
Maybe we can combine the new |
SebaLukas
reviewed
Nov 7, 2024
modules/EvAPI/EvAPI.hpp
Outdated
|
|
||
| private: | ||
| std::mutex session_info_mutex; | ||
| std::string state = "Unknown"; |
There was a problem hiding this comment.
I think, state should be types::board_support_common::event and not std::string
MarzellT
reviewed
Nov 7, 2024
modules/EvAPI/EvAPI.hpp
Outdated
|
|
||
| private: | ||
| std::mutex session_info_mutex; | ||
| std::string state = "Unknown"; |
There was a problem hiding this comment.
I think an enum could be preferable here. It would make it clearer what the possible values can be
modules/EvAPI/EvAPI.cpp
Outdated
| this->state = "Unknown"; | ||
| } | ||
|
|
||
| void EvSessionInfo::update_state(const std::string& event) { |
There was a problem hiding this comment.
Maybe rename event here? I think it might be a little bit confusing to call this variable event when it actually represents the state
|
|
||
| std::list<std::unique_ptr<EvSessionInfo>> info; | ||
|
|
||
| const std::string api_base = "everest_api/"; |
There was a problem hiding this comment.
Perhaps make this a static inline constexpr std::string_view
modules/EvAPI/EvAPI.cpp
Outdated
| EvSessionInfo::operator std::string() { | ||
| std::lock_guard<std::mutex> lock(this->session_info_mutex); | ||
|
|
||
| auto now = date::utc_clock::now(); |
modules/EvAPI/EvAPI.cpp
Outdated
Comment on lines
48
to
60
| std::string var_base = ev_base + "/var/"; | ||
|
|
||
| std::string var_ev_info = var_base + "ev_info"; | ||
| ev->subscribe_ev_info([this, &ev, var_ev_info](types::evse_manager::EVInfo ev_info) { | ||
| json ev_info_json = ev_info; | ||
| this->mqtt.publish(var_ev_info, ev_info_json.dump()); | ||
| }); | ||
|
|
||
| std::string var_session_info = var_base + "session_info"; | ||
| ev->subscribe_bsp_event([this, var_session_info, &session_info](const auto& bsp_event) { | ||
| session_info->update_state(types::board_support_common::event_to_string(bsp_event.event)); | ||
| this->mqtt.publish(var_session_info, *session_info); | ||
| }); |
There was a problem hiding this comment.
I think it could improve readability if those blocks are refactored to static functions like publish_ev_info and publish_session_info
| }; | ||
|
|
||
| void CarSimulation::simulate_soc() { | ||
| double ms = |
| double ms = | ||
| std::chrono::duration_cast<std::chrono::milliseconds>(std::chrono::steady_clock::now() - timepoint_last_update) | ||
| .count(); | ||
| double factor = (1.0 / 60.0 / 60.0 / 1000.0) * ms; |
| const module::Conf& config; | ||
| std::chrono::time_point<std::chrono::steady_clock> timepoint_last_update; | ||
| double charge_current_a{0}; | ||
| double charge_voltage_v{0}; |
There was a problem hiding this comment.
Is there a reason this is a class member? As far as I can see this is only used in one function where it's just copying the value of the config so it could live only there
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
This is was only used for AC, where we now get it via the config Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
…e enum Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review