API: fix documentation for legacy enable/disable #935
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The API module provides an "easy" legacy interface for enabling/disabling a connector.
The generic enable/disable call it maps to was not documented correctly. A value used incorrect case, and the priority did not reflect what the actual code did.
I'm not sure whether it was actually intentional that the priority is set to 100 in the code.
everest-core/modules/API/API.cpp
Lines 408 to 409 in 1e06aaa
The priority is a range from 0 to 10000, and 0 seems more reasonable:
everest-core/modules/EvseManager/Charger.cpp
Line 1511 in 1e06aaa
Issue ticket number and link
Checklist before requesting a review