Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlock in states A/B instead of B/C #939

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Unlock in states A/B instead of B/C #939

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2fb523
Unlock in states A/B instead of B/C
Oct 30, 2024
f7dbac4
Unlock in A/B/C
Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/EvseManager/IECStateMachine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,8 @@ void IECStateMachine::connector_force_unlock() {
cp = cp_state;
}

if (cp == RawCPState::B or cp == RawCPState::C) {
// Unlocking in state C violates regulations and risks the user.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only speculate but the reasoning why its only force unlocked in B and C is because we already unlock (without the force) when we enter state A (see same file)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think that in general force unlock should always unlock but before doing so open the contactors (and wait for state A or B)

if (cp == RawCPState::A or cp == RawCPState::B) {
force_unlocked = true;
check_connector_lock();
}
Expand Down
Loading