Changed connector_id and evse_id properties to optional in OcppTransactionEvent #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…optional, since the those properties are also optional TransactionEvent message in OCPP Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
Pietfried
requested review from
hikinggrass,
maaikez and
corneliusclaussen
as code owners
hikinggrass
approved these changes
Nov 6, 2024
hikinggrass
deleted the
refactor/make-evse-type-optional-in-transaction-event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Made the evse_id and connector_id properties of OcppTransactionEvent optional, since the those properties are also optional TransactionEvent message in OCPP
Issue ticket number and link
Checklist before requesting a review