-
Notifications
You must be signed in to change notification settings - Fork 471
Conversation
@EYHN 还有,我看你3.0的PR里改了好多,除了commit里提到的内容,很多都是语法风格之类的修改吗? |
好吧,你的${config.hiddenOnMobile ? ...:...}实现貌似比我的简单很多,你可以接着更改QwQ |
readme.zh-CN.md
Outdated
<%- live2d({ | ||
model: "nipsilon" | ||
}) %> | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不可用
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--已查阅并更新
代码中加入了相关内容,请查阅
应在此补充设置优先顺序
"nico": "nito/nico.model.json", | ||
"nito": "nito/nito.model.json", | ||
"nipsilon": "nito/nipsilon.model.json", | ||
"nietzsche": "nito/nietzche.model.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nito系列 (i.e. ni-j
,nico
,nito
, nipsilon
, nietzche
) 都用不了了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--已查阅并更新
请仔细再次检查确保无误
index.js
Outdated
|
||
registerDir('live2d/assets/', path.resolve(__dirname, './assets')); | ||
registerFile('live2d/script.js', path.resolve(__dirname, './dist/bundle.js')) | ||
|
||
hexo.extend.helper.register('live2d', function (config) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的 config 参数是否应该删除
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯,意思是这个hexo.helper只要传递一堆字符串就可以了吗?那个function(config)里的config变量是没用的?
ejs不可用: 这里的 config 参数是否应该删除: nito系列 (i.e. ni-j ,nico,nito, nipsilon,nietzche) 都用不了了 话说如果我要更改pr的comment的话,直接git push我fork的repo,然后pr上做什么操作直接跟进到我repo的最近提交呢? |
index.js
Outdated
<script type="text/javascript"> | ||
(function(){ | ||
if(device.mobile()){ | ||
if(${config.mobileShow}){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
常见作者的pr“3.0”
``` | ||
|
||
|
||
- `model`: 模型名称 默认值: z16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
测试是否可用
index.js
Outdated
|
||
|
||
var config = Object.assign( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
更好地传递config
index.js
Outdated
|
||
registerDir('live2d/assets/', path.resolve(__dirname, './assets')); | ||
registerFile('live2d/script.js', path.resolve(__dirname, './dist/bundle.js')) | ||
|
||
hexo.extend.helper.register('live2d', function (config) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯,意思是这个hexo.helper只要传递一堆字符串就可以了吗?那个function(config)里的config变量是没用的?
@EYHN 我正在改写代码,然后请看看我上面的反馈,谢谢。 |
|
ejs中传入模型会导致错误如何解决?emmm,或者是改成swig传入模型设置? |
@EYHN |
参照了 |
目前所有改动均已完成,请检查。 |
Fixed:
仅生成选择的模型(#14) 模型列表移除(#14)
增加模型左右设置(#10)(#19)(#21)(#23) 增加移动端模型更多功能(#12)
New README
Deleted package-lock.json to solve dependencies problems
Updates dependencies
Tried to fix (#26) Uncaught TypeError.
然后 @EYHN 你3个月前发的#15 现在还有效吗?
有空想把您的pr 3.0 merge到下一个pr中。
可用性与稳定性请大大仔细验证 xiazeyu未经仔细的测试,初步保证可用性
然后一些issues如果解决了可以关闭。
觉得可以请等待最终完成然后发布npm新版本