Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

midis update #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

midis update #41

wants to merge 1 commit into from

Conversation

jetrotal
Copy link
Contributor

Uploading Midis colected through last year.

uploading Midis colected through last year.
@fdelapena fdelapena requested a review from Ghabry February 7, 2023 07:11
@Mimigris
Copy link

Mimigris commented May 18, 2023

I decided to do a review of this pull request since it's something with a lot of content to review. Note that you are not forced to take everything into account, it's just what I thought should be changed. Outside of these specific tracks/what I pointed to change in these specific tracks, everything else seems to be good to go.

Loop differences:

(I'm not sure if it's the plan to be 1:1 with the RTP for this but there is no reason to make them change compared to it if you want my opinion)

Tracks that don't loop in the 2k(3) RTP but does in the OpenRTP:

  • 2003Hero's Return
  • JDoubt
  • JEndofBattle1
  • JEndofBattle2
  • JEndofBattle3
  • JEndofBattle4
  • JFanfare1
  • JFanfare2
  • JFanfare3
  • JFanfare4
  • JFanfare5
  • JFanfare6
  • JInn1
  • JInn2
  • JItem
  • JJoke2

It does not really make sense for a jingle to loop.

Tracks that loop in the 2k(3) RTP but not in the OpenRTP:

  • 2003Cathedral
  • 2003Deep Memory
  • 2003Young Memories
  • Parting 2
  • Victory

These tracks should be able to properly be looped by removing the end part and making it restart at a a correct tempo compared to the rest of the track.

I think that the tracks that I have listed in the Loop differences part could all be used as-is by just changing this property if we want to be accurate compared to the 2k(3) RTP.

Tracks that may be too short and/or repetitive:

  • 2003Creeping Darkness
  • 2003Dark Altar
  • 2003Machine Fortress
  • Field 2
  • Hero1
  • Hero2
  • Mystery2
  • Wrath

I think that some of them may have to be changed if you want my opinion, while they may sound good they may be a bit too short to encourage people to use them.

Tracks that are too quiet compared to the others:

  • Boss 3

Specific issues:

  • 2003DesertedMansion seems to not loop correctly sometimes when I listen to it in RPG Maker. I have not took a look at it deeply, but there may have something to change there to how it loops.
  • 2003Lonesome Journey has an issue with how the volume is set, causing issues in the RPG_RT and RPG Maker (See RPG_RT bug: Volume setting ignored when playing some notes from a midi not replicated in the Player Player#2995). While it does not directly affect the Player (EDIT December 2023: this now also affects the Player), I think that it could be a good thing to remove it to avoid potential issues.
  • 2003Ancient City, 2003Steady Breeze and Fairy 1 have an issue where when played on WildMidi, the song will oversaturate at some point when playing before it loops, would probably need to be checked.

Nitpicking from my side (you don't have to take it into account):

  • 2003Panic is good, but does not convey panic enough
  • J2003Horn is not a horn or does not sound like one to me

@Ghabry
Copy link
Member

Ghabry commented May 19, 2023

Not looping means btw that they have the loop point at the end making the track silent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants