-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
midis update #41
base: master
Are you sure you want to change the base?
midis update #41
Conversation
uploading Midis colected through last year.
I decided to do a review of this pull request since it's something with a lot of content to review. Note that you are not forced to take everything into account, it's just what I thought should be changed. Outside of these specific tracks/what I pointed to change in these specific tracks, everything else seems to be good to go. Loop differences:(I'm not sure if it's the plan to be 1:1 with the RTP for this but there is no reason to make them change compared to it if you want my opinion) Tracks that don't loop in the 2k(3) RTP but does in the OpenRTP:
It does not really make sense for a jingle to loop. Tracks that loop in the 2k(3) RTP but not in the OpenRTP:
These tracks should be able to properly be looped by removing the end part and making it restart at a a correct tempo compared to the rest of the track. I think that the tracks that I have listed in the Loop differences part could all be used as-is by just changing this property if we want to be accurate compared to the 2k(3) RTP. Tracks that may be too short and/or repetitive:
I think that some of them may have to be changed if you want my opinion, while they may sound good they may be a bit too short to encourage people to use them. Tracks that are too quiet compared to the others:
Specific issues:
Nitpicking from my side (you don't have to take it into account):
|
Not looping means btw that they have the loop point at the end making the track silent |
Uploading Midis colected through last year.